Adapt protobuf test#611
Merged
Merged
Conversation
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
thehoul
force-pushed
the
adapt-protobuf-test
branch
from
February 5, 2026 10:44
d0891ba to
530031c
Compare
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
This was referenced Feb 5, 2026
thehoul
marked this pull request as ready for review
February 5, 2026 10:48
jbsv
reviewed
Feb 23, 2026
jbsv
left a comment
jbsv
left a comment
Contributor
There was a problem hiding this comment.
Just one question to be sure about the test.. Otherwise looks good to me 👍
AnomalRoil
reviewed
Feb 23, 2026
AnomalRoil
left a comment
AnomalRoil
left a comment
Contributor
There was a problem hiding this comment.
I am a bit puzzled at the int removal parts.
|
|
||
| type test struct { | ||
| Bool bool `protobuf:"boolean,opt"` | ||
| I int |
Contributor
There was a problem hiding this comment.
wait, are we not supporting encoding and decoding the int type?
Contributor
There was a problem hiding this comment.
The int type has no deterministic size (https://go.dev/ref/spec#Numeric_types), and we want to avoid that across architectures.
|
❌ The last analysis has failed. |
thehoul
force-pushed
the
move-protobuf-to-internal
branch
from
February 27, 2026 11:49
2f265e7 to
fab66e0
Compare
Co-authored-by: AnomalRoil <AnomalRoil@users.noreply.github.com>
thehoul
force-pushed
the
adapt-protobuf-test
branch
from
February 27, 2026 11:50
78c552f to
1743700
Compare
thehoul
changed the base branch from
move-protobuf-to-internal
to
backward-compatible-marshalling
February 27, 2026 12:04
thehoul
merged commit Feb 27, 2026
bbf3d62
into
backward-compatible-marshalling
10 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #608
Adapt protobuf test imported in internal to work in V4 and in the pipeline when compiling on 32b