Backward compatible marshalling#619
Merged
Merged
Conversation
Co-authored-by: AnomalRoil <AnomalRoil@users.noreply.github.com>
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
This was referenced Feb 27, 2026
Adapt protobuf test
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
thehoul
requested review from
AnomalRoil and
jbsv
and removed request for
AnomalRoil
February 27, 2026 13:51
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for incompatible marshaling between V3 and V4, specifically regarding the encoding of
Dealstruct in both Pedersen and Rabin's VSS and the underlying structureShare.PriSharerepresenting a private share of a polynomial.The problem is raised by the changes in the aforementioned structures making them incompatible when using DEDIS' protobuf (www.github.com/dedis/protobuf), hereafter referred to simply as protobuf). Pedersen and Rabin's VSS implementation use protobuf internally in V3 causing the issue to be unreachable for users of Kyber. For more details, see #607.
The solution implements custom method for the affected structures to marshal and unmarshal when interacting with V3 nodes to ensure compatibility. As a result, we also moved protobuf to internal and removed it as dependency in an effort to gradually get rid of protobuf altogether.