Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SentenceTransformersTextEmbedder supports config_kwargs #8432

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alperkaya
Copy link
Contributor

Related Issues

Proposed Changes:

How did you test it?

CI, update unittests

Notes for the reviewer

Checklist

@alperkaya alperkaya requested a review from a team as a code owner October 1, 2024 15:43
@alperkaya alperkaya requested review from julian-risch and removed request for a team October 1, 2024 15:43
@coveralls
Copy link
Collaborator

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11146015696

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 90.301%

Files with Coverage Reduction New Missed Lines %
components/embedders/sentence_transformers_text_embedder.py 2 96.23%
components/converters/markdown.py 9 40.0%
Totals Coverage Status
Change from base Build 11127612635: 0.001%
Covered Lines: 7458
Relevant Lines: 8259

💛 - Coveralls

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment regarding the linter config you changed, and please also add the release-notes.

Thanks for your contribution!

pyproject.toml Outdated Show resolved Hide resolved
@julian-risch julian-risch changed the title feat: add config_kwargs feat: SentenceTransformersTextEmbedder supports config_kwargs Oct 2, 2024
@alperkaya alperkaya requested a review from a team as a code owner October 2, 2024 14:41
@alperkaya alperkaya requested review from dfokina and removed request for a team October 2, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exposing config_kwargs in sentence_transformers component
3 participants