chore: upgrade v4.3.0#129
Conversation
Review Summary by QodoUpgrade Aztec boilerplate to v4.3.0-rc.1
WalkthroughsDescription• Upgrade Aztec dependencies from 4.2.0 to 4.3.0-rc.1 • Update Noir contract dependency tag to v4.3.0-rc.1 • Add @aztec/foundation resolution to package.json • Update pre-commit hook to use aztec-nargo command Diagramflowchart LR
A["Current Version 4.2.0"] -- "Upgrade dependencies" --> B["Version 4.3.0-rc.1"]
B -- "Update Noir tag" --> C["Nargo.toml v4.3.0-rc.1"]
B -- "Add foundation resolution" --> D["package.json resolutions"]
B -- "Update pre-commit" --> E["aztec-nargo command"]
File Changes1. package.json
|
Code Review by Qodo
1. Undeclared aztec-nargo hook
|
| @@ -1,2 +1,2 @@ | |||
| nargo fmt | |||
| aztec-nargo fmt | |||
There was a problem hiding this comment.
1. Undeclared aztec-nargo hook 🐞 Bug ☼ Reliability
The pre-commit hook now executes aztec-nargo fmt, but aztec-nargo is not declared in package.json, so a clean checkout with only yarn install cannot guarantee the command exists and commits will fail. This is a new workflow dependency introduced by the PR.
Agent Prompt
## Issue description
`.husky/pre-commit` calls `aztec-nargo fmt` directly, but the repo does not declare/provide an `aztec-nargo` binary via `package.json`. This can break `git commit` on machines where `aztec-nargo` isn’t already installed on PATH.
## Issue Context
Husky is enabled via `prepare: husky`, so contributors will hit this hook during commits.
## Fix Focus Areas
- .husky/pre-commit[1-2]
- package.json[8-19]
- package.json[23-33]
- README.md[30-34]
## What to change
Pick one approach and make it deterministic after `yarn install`:
1. **Prefer:** add a package-provided command and run it via yarn (e.g., `"format:nr": "aztec-nargo fmt"` then in the hook `yarn -s format:nr`) *and* add the dependency that provides `aztec-nargo` (if it exists as an npm package/binary).
2. If `aztec-nargo` is intentionally external (installed with the Aztec toolchain), **document it explicitly** in README Setup and consider guarding the hook with a clear error message when the binary is missing.
3. Alternatively, if supported, invoke formatting through an existing tool that the project already requires (e.g., an `aztec ...` subcommand) rather than a separate binary.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
False positive — aztec-nargo ships with the Aztec CLI toolchain (already listed as a prerequisite in the README, same as aztec compile/codegen/test used in our scripts) and isn't published to npm, so it can't be declared as a package dependency.
This comment has been minimized.
This comment has been minimized.
9c7152a
|
Persistent review updated to latest commit 9c7152a |
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
No description provided.