Skip to content

chore: upgrade v4.3.0#129

Merged
wei3erHase merged 2 commits into
devfrom
chore/v4.3.0-rc.1
May 20, 2026
Merged

chore: upgrade v4.3.0#129
wei3erHase merged 2 commits into
devfrom
chore/v4.3.0-rc.1

Conversation

@0xLeopoldo

Copy link
Copy Markdown
Contributor

No description provided.

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Upgrade Aztec boilerplate to v4.3.0-rc.1

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Upgrade Aztec dependencies from 4.2.0 to 4.3.0-rc.1
• Update Noir contract dependency tag to v4.3.0-rc.1
• Add @aztec/foundation resolution to package.json
• Update pre-commit hook to use aztec-nargo command
Diagram
flowchart LR
  A["Current Version 4.2.0"] -- "Upgrade dependencies" --> B["Version 4.3.0-rc.1"]
  B -- "Update Noir tag" --> C["Nargo.toml v4.3.0-rc.1"]
  B -- "Add foundation resolution" --> D["package.json resolutions"]
  B -- "Update pre-commit" --> E["aztec-nargo command"]
Loading

Grey Divider

File Changes

1. package.json Dependencies +11/-10

Update all Aztec dependencies to 4.3.0-rc.1

• Bump project version from 4.2.0 to 4.3.0-rc.1
• Update all @aztec/* dependencies to 4.3.0-rc.1
• Update aztecVersion config to 4.3.0-rc.1
• Add @aztec/foundation 4.3.0-rc.1 to resolutions

package.json


2. src/nr/counter_contract/Nargo.toml Dependencies +1/-1

Update Noir aztec dependency tag

• Update aztec dependency tag from v4.2.0 to v4.3.0-rc.1

src/nr/counter_contract/Nargo.toml


3. .husky/pre-commit ⚙️ Configuration changes +1/-1

Update pre-commit hook command

• Replace nargo with aztec-nargo command in pre-commit hook

.husky/pre-commit


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented May 19, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Undeclared aztec-nargo hook 🐞 Bug ☼ Reliability
Description
The pre-commit hook now executes aztec-nargo fmt, but aztec-nargo is not declared in
package.json, so a clean checkout with only yarn install cannot guarantee the command exists and
commits will fail. This is a new workflow dependency introduced by the PR.
Code

.husky/pre-commit[1]

Evidence
The hook now invokes aztec-nargo but the repo’s JS dependencies/scripts don’t include an
aztec-nargo package/binary, and the README setup steps don’t mention installing it; Husky is
enabled via the prepare script so this hook will execute on commit.

.husky/pre-commit[1-2]
package.json[8-19]
package.json[23-33]
README.md[30-34]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`.husky/pre-commit` calls `aztec-nargo fmt` directly, but the repo does not declare/provide an `aztec-nargo` binary via `package.json`. This can break `git commit` on machines where `aztec-nargo` isn’t already installed on PATH.

## Issue Context
Husky is enabled via `prepare: husky`, so contributors will hit this hook during commits.

## Fix Focus Areas
- .husky/pre-commit[1-2]
- package.json[8-19]
- package.json[23-33]
- README.md[30-34]

## What to change
Pick one approach and make it deterministic after `yarn install`:
1. **Prefer:** add a package-provided command and run it via yarn (e.g., `"format:nr": "aztec-nargo fmt"` then in the hook `yarn -s format:nr`) *and* add the dependency that provides `aztec-nargo` (if it exists as an npm package/binary).
2. If `aztec-nargo` is intentionally external (installed with the Aztec toolchain), **document it explicitly** in README Setup and consider guarding the hook with a clear error message when the binary is missing.
3. Alternatively, if supported, invoke formatting through an existing tool that the project already requires (e.g., an `aztec ...` subcommand) rather than a separate binary.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Benchmark stack out-of-sync 🐞 Bug ≡ Correctness
Description
The repo upgrades @aztec/* to 4.3.0-rc.1 but keeps @defi-wonderland/aztec-benchmark on a 4.2.0
prerelease, so yarn benchmark/CI benchmark workflows will run with a different Aztec JS/wallet
stack than the project dependencies. yarn.lock shows aztec-benchmark depends on @aztec/aztec.js and
@aztec/wallets 4.2.0 while 4.3.0-rc.1 is also present, creating a mixed-version runtime.
Code

package.json[R24-31]

Evidence
The repo now depends on Aztec 4.3.0-rc.1, but the benchmark package and benchmark CI workflows are
still pinned to a 4.2.0 prerelease; yarn.lock also shows the benchmark package pulls
@aztec/aztec.js/@aztec/wallets 4.2.0 while 4.3.0-rc.1 is present, proving a mixed-version benchmark
runtime.

package.json[23-33]
yarn.lock[1405-1414]
yarn.lock[420-452]
.github/workflows/pr-checks.yml[15-16]
.github/workflows/update-baseline.yml[16-19]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`@defi-wonderland/aztec-benchmark` and the reusable benchmark workflows are pinned to a 4.2.0 prerelease while the repo’s `@aztec/*` dependencies are now 4.3.0-rc.1. This makes benchmark runs and benchmark CI operate with an older Aztec stack than the codebase.

## Issue Context
- `package.json` pins `@defi-wonderland/aztec-benchmark` to a `4.2.0-prerelease.*` tarball.
- The same prerelease ref is used in `.github/workflows/*` for benchmark workflows.
- `yarn.lock` shows aztec-benchmark depends on `@aztec/aztec.js@4.2.0`/`@aztec/wallets@4.2.0` while the repo uses `4.3.0-rc.1`, resulting in mixed versions.

## Fix Focus Areas
- package.json[23-33]
- yarn.lock[420-452]
- yarn.lock[1405-1414]
- .github/workflows/pr-checks.yml[15-16]
- .github/workflows/update-baseline.yml[16-19]

## What to change
1. Bump `@defi-wonderland/aztec-benchmark` to a release/prerelease that is built for Aztec `4.3.0-rc.1` (or whatever benchmark release matches this Aztec RC).
2. Update the referenced benchmark reusable workflows (`pr-benchmark.yml` / `update-baseline.yml`) to the corresponding benchmark workflow ref.
3. Regenerate `yarn.lock` so benchmark and Aztec libraries resolve consistently for the intended stack.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

  • Author self-review: I have reviewed the code review findings, and addressed the relevant ones.

Qodo Logo

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes May 19, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

Comment thread .husky/pre-commit
@@ -1,2 +1,2 @@
nargo fmt
aztec-nargo fmt

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Undeclared aztec-nargo hook 🐞 Bug ☼ Reliability

The pre-commit hook now executes aztec-nargo fmt, but aztec-nargo is not declared in
package.json, so a clean checkout with only yarn install cannot guarantee the command exists and
commits will fail. This is a new workflow dependency introduced by the PR.
Agent Prompt
## Issue description
`.husky/pre-commit` calls `aztec-nargo fmt` directly, but the repo does not declare/provide an `aztec-nargo` binary via `package.json`. This can break `git commit` on machines where `aztec-nargo` isn’t already installed on PATH.

## Issue Context
Husky is enabled via `prepare: husky`, so contributors will hit this hook during commits.

## Fix Focus Areas
- .husky/pre-commit[1-2]
- package.json[8-19]
- package.json[23-33]
- README.md[30-34]

## What to change
Pick one approach and make it deterministic after `yarn install`:
1. **Prefer:** add a package-provided command and run it via yarn (e.g., `"format:nr": "aztec-nargo fmt"` then in the hook `yarn -s format:nr`) *and* add the dependency that provides `aztec-nargo` (if it exists as an npm package/binary).
2. If `aztec-nargo` is intentionally external (installed with the Aztec toolchain), **document it explicitly** in README Setup and consider guarding the hook with a clear error message when the binary is missing.
3. Alternatively, if supported, invoke formatting through an existing tool that the project already requires (e.g., an `aztec ...` subcommand) rather than a separate binary.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive — aztec-nargo ships with the Aztec CLI toolchain (already listed as a prerequisite in the README, same as aztec compile/codegen/test used in our scripts) and isn't published to npm, so it can't be declared as a package dependency.

qodo-code-review[bot]
qodo-code-review Bot previously approved these changes May 19, 2026
@github-actions

This comment has been minimized.

@qodo-code-review

qodo-code-review Bot commented May 20, 2026

Copy link
Copy Markdown

Persistent review updated to latest commit 9c7152a

@0xLeopoldo 0xLeopoldo changed the title chore: upgrade v4.3.0-rc.1 chore: upgrade v4.3.0 May 20, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Re-trigger cubic

@github-actions

Copy link
Copy Markdown

Benchmark Comparison

CPU Cores RAM Arch
AMD EPYC 7763 64-Core Processor 16 63 GiB x64

Contract: counter

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
🟢 increment 449,058 416,973 -32,085 (-7.1%) 192 192 627,249 627,207 -42 (-0.0%) N/A N/A

@wei3erHase wei3erHase left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wei3erHase wei3erHase merged commit 832eda1 into dev May 20, 2026
8 checks passed
@wei3erHase wei3erHase deleted the chore/v4.3.0-rc.1 branch May 20, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants