Skip to content

chore: upgrade v4.3.0 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wei3erHase merged 2 commits into from
May 20, 2026
Merged

chore: upgrade v4.3.0 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53ebcd1
chore: upgrade v4.3.0-rc.1
0xLeopoldo May 19, 2026
9c7152a
chore: upgrade to v4.3.0
0xLeopoldo May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nargo fmt
aztec-nargo fmt

@qodo-code-review qodo-code-review Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Undeclared aztec-nargo hook 🐞 Bug ☼ Reliability

The pre-commit hook now executes aztec-nargo fmt, but aztec-nargo is not declared in
package.json, so a clean checkout with only yarn install cannot guarantee the command exists and
commits will fail. This is a new workflow dependency introduced by the PR.
Agent Prompt 
## Issue description
`.husky/pre-commit` calls `aztec-nargo fmt` directly, but the repo does not declare/provide an `aztec-nargo` binary via `package.json`. This can break `git commit` on machines where `aztec-nargo` isn’t already installed on PATH.

## Issue Context
Husky is enabled via `prepare: husky`, so contributors will hit this hook during commits.

## Fix Focus Areas
- .husky/pre-commit[1-2]
- package.json[8-19]
- package.json[23-33]
- README.md[30-34]

## What to change
Pick one approach and make it deterministic after `yarn install`:
1. **Prefer:** add a package-provided command and run it via yarn (e.g., `"format:nr": "aztec-nargo fmt"` then in the hook `yarn -s format:nr`) *and* add the dependency that provides `aztec-nargo` (if it exists as an npm package/binary).
2. If `aztec-nargo` is intentionally external (installed with the Aztec toolchain), **document it explicitly** in README Setup and consider guarding the hook with a clear error message when the binary is missing.
3. Alternatively, if supported, invoke formatting through an existing tool that the project already requires (e.g., an `aztec ...` subcommand) rather than a separate binary.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@0xLeopoldo 0xLeopoldo May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive — aztec-nargo ships with the Aztec CLI toolchain (already listed as a prerequisite in the README, same as aztec compile/codegen/test used in our scripts) and isn't published to npm, so it can't be declared as a package dependency.

yarn lint-staged
21 changes: 11 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aztec-boilerplate",
"version": "4.2.0",
"version": "4.3.0",
"repository": "https://github.com/defi-wonderland/aztec-boilerplate.git",
"author": "Wonderland",
"license": "MIT",
Expand All @@ -21,13 +21,13 @@
"*.{js,ts}": "prettier --write -u"
},
"dependencies": {
"@aztec/accounts": "4.2.0",
"@aztec/aztec.js": "4.2.0",
"@aztec/entrypoints": "4.2.0",
"@aztec/noir-contracts.js": "4.2.0",
"@aztec/pxe": "4.2.0",
"@aztec/stdlib": "4.2.0",
"@aztec/wallets": "4.2.0",
"@aztec/accounts": "4.3.0",
"@aztec/aztec.js": "4.3.0",
"@aztec/entrypoints": "4.3.0",
"@aztec/noir-contracts.js": "4.3.0",
"@aztec/pxe": "4.3.0",
"@aztec/stdlib": "4.3.0",
"@aztec/wallets": "4.3.0",
"@defi-wonderland/aztec-benchmark": "https://github.com/defi-wonderland/aztec-benchmark/releases/download/prerelease-022ee63/defi-wonderland-aztec-benchmark-4.2.0-prerelease.022ee63.tgz",
"@types/node": "25.0.10"
},
Expand All @@ -43,14 +43,15 @@
"vitest": "4.0.17"
},
"config": {
"aztecVersion": "4.2.0"
"aztecVersion": "4.3.0"
},
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"engines": {
"node": ">=22.0.0",
"yarn": ">=1.22.0"
},
"resolutions": {
"@noble/hashes": "1.8.0"
"@noble/hashes": "1.8.0",
"@aztec/foundation": "4.3.0"
}
}
2 changes: 1 addition & 1 deletion src/nr/counter_contract/Nargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ compiler_version = ">=1.0.0"
authors = [""]

[dependencies]
aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v4.2.0", directory = "noir-projects/aztec-nr/aztec" }
aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v4.3.0", directory = "noir-projects/aztec-nr/aztec" }
Loading
Loading