chore: nft contract tests #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorsal
requested changes
Apr 8, 2025
src/nft_contract/src/test.nr
Outdated
Comment on lines
2
to
5
| // mod transfer_in_private; | ||
| // mod transfer_in_public; | ||
| // mod transfer_to_private; | ||
| // mod transfer_to_public; |
0xShaito
reviewed
Apr 10, 2025
0xShaito
reviewed
Apr 10, 2025
0xShaito
reviewed
Apr 10, 2025
wei3erHase
reviewed
Apr 14, 2025
src/nft_contract/src/main.nr
Outdated
| @@ -3,6 +3,7 @@ mod test; | |||
|
|
|||
| use aztec::macros::aztec; | |||
|
|
|||
| /// @dev NFT only supports public minting and public/private transfers | |||
There was a problem hiding this comment.
no longer relevant
daopunk
changed the base branch from
feat/nft-contract
to
refactor/nft-contract
wei3erHase
reviewed
Apr 25, 2025
| @@ -1,5 +1,6 @@ | |||
| use aztec::{ | |||
| context::{PrivateContext, UnconstrainedContext}, | |||
| context::{PrivateContext, UtilityContext}, | |||
| macros::functions::utility, | |||
There was a problem hiding this comment.
are we using #[utility] in this file?
There was a problem hiding this comment.
yes for:
#[utility]
unconstrained fn get_private_nfts
0xShaito
requested changes
Apr 28, 2025
0xmoebius
reviewed
Apr 28, 2025
|
|
||
| // Verify initial state | ||
| utils::assert_owns_private_nft(nft_contract_address, owner, token_id); | ||
| assert(utils::get_nft_exists(nft_contract_address, token_id), "NFT should exist before burn"); |
There was a problem hiding this comment.
NIT: get_nft_exists could be a method of utils (utils::assert_nft_exists) like assert_owns_private_nft is. just for consistency
wei3erHase
reviewed
Apr 28, 2025
src/nft_contract/src/test/view.nr
Outdated
Comment on lines
5
to
21
| #[test] | ||
| unconstrained fn name_is_set() { | ||
| let (env, nft_contract_address, owner, minter, recipient) = utils::setup_with_minter(false); | ||
|
|
||
| let name = NFT::at(nft_contract_address).public_get_name().view(&mut env.public()); | ||
| let expected_name = FieldCompressedString::from_string("TestNFT000000000000000000000000"); | ||
| assert(name == expected_name, "name is not set correctly"); | ||
| } | ||
|
|
||
| #[test] | ||
| unconstrained fn symbol_is_set() { | ||
| let (env, nft_contract_address, owner, minter, recipient) = utils::setup_with_minter(false); | ||
|
|
||
| let symbol = NFT::at(nft_contract_address).public_get_symbol().view(&mut env.public()); | ||
| let expected_symbol = FieldCompressedString::from_string("TNFT000000000000000000000000000"); | ||
| assert(symbol == expected_symbol, "symbol is not set correctly"); | ||
| } |
There was a problem hiding this comment.
oh, we should add these tests (and getters) on the token @0xShaito u tracking this?
xorsal
approved these changes
Apr 28, 2025
xorsal
approved these changes
Apr 29, 2025
0xShaito
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AZT-158