test(fix): expecting revert call to succeed #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ contract SymbolicGreeter is SymTest, Test { | |||
| (_success,) = address(targetContract).call(abi.encodeCall(Greeter.setGreeting, (''))); | |||
|
|
|||
| // Output condition check | |||
| vm.assume(_success); // discard failing calls | |||
There was a problem hiding this comment.
is there a reason we exclude instead of testing in the post-condition state? This should rather be if(success) assert(string != '') else assert(string=='') no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐧 🐧 🐧
The test
check_validState_greeterNeverEmptywas breaking because in the second calladdress(targetContract).call(abi.encodeCall(Greeter.setGreeting, ('')));we expect the call to revert due to empty string being passed, but thevm.assumecheck the call was successful🐧 🐧 🐧