Skip to content

test(fix): expecting revert call to succeed #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test(fix): expecting revert call to succeed #102

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a8bdd0
test(fix): expecting revert call to succeed
0xChin Mar 27, 2025
065316d
test(symbolic): improve greeterNeverEmpty test
0xChin Mar 27, 2025
7716ba0
refactor: remove condition for length=0 createString
0xChin Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/invariants/symbolic/Greeter.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ contract SymbolicGreeter is SymTest, Test {
(_success,) = address(targetContract).call(abi.encodeCall(Greeter.setGreeting, ('')));

// Output condition check
vm.assume(_success); // discard failing calls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we exclude instead of testing in the post-condition state? This should rather be if(success) assert(string != '') else assert(string=='') no?

vm.assume(!_success); // expect call to fail
assert(keccak256(bytes(targetContract.greeting())) != keccak256(bytes('')));
}

Expand Down
Loading