feat: Allow LargeUTF8 -> String and LargeBinary -> Binary in arrow conversion #1294
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
+ Coverage 83.66% 83.68% +0.01%
==========================================
Files 108 108
Lines 25926 25932 +6
Branches 25926 25932 +6
==========================================
+ Hits 21691 21700 +9
+ Misses 3145 3144 -1
+ Partials 1090 1088 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zachschuermann
changed the title
|
It would help to have these changes on read paths too |
|
@chiragjn could you open a new issue? we have discussed the "Large" versions for log metadata (LargeUtf8, etc.) - if you have some more details will help us to investigate/prioritize! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR relaxes type-checking rules to allow
LargeUtf8conversion toSTRINGandLargeBinaryconversion toBINARY. With this PR Delta kernel will allow committing arrow record batches that useLargeUtf8or that are built usingLargeStringBuilderor corresponding types for buildingLargeBinary.The main limitation that non-large variations of string and binary types impose is that they can hold up to 2 GBs of data, which makes it impossible to do kernel commits if there is a string or binary column larger than 2 GB. With this PR clients can just pass
RecordBatchthat usesLargeUtf8orLargeBinaryas column types.How was this change tested?
New UT