chore(cargo): add cargo-machete to detect and remove unused dependencies #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvaleye
requested review from
hntd187,
ion-elgreco,
roeap and
rtyler
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3713 +/- ##
==========================================
+ Coverage 75.30% 75.33% +0.03%
==========================================
Files 145 145
Lines 43773 43751 -22
Branches 43773 43751 -22
==========================================
Hits 32962 32962
+ Misses 9217 9195 -22
Partials 1594 1594 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fvaleye
force-pushed
the
chore/add-cargo-machete-in-ci
branch
from
b9d6bf3 to
16f18bf
Compare
Signed-off-by: Florian Valeye <[email protected]>
fvaleye
force-pushed
the
chore/add-cargo-machete-in-ci
branch
from
16f18bf to
5089cb3
Compare
roeap
approved these changes
Aug 28, 2025
| async-trait = { workspace = true } | ||
| bytes = { workspace = true } | ||
| futures = { workspace = true } | ||
| tracing = { workspace = true } |
There was a problem hiding this comment.
I think here @rtyler might say that adding logging to the crates is the way to go and every crate should have tracing as a required dependency :D.
That said, I am fairly sure we already have an issue to track this.
Comment on lines
+170
to
+171
| [package.metadata.cargo-machete] | ||
| ignored = ["foyer"] |
There was a problem hiding this comment.
we can remove this for now I think.
I believe this may have slipped though while i was working on #3440. It will get added back once we merge that PR, but then potentially also as optional.
fvaleye
added a commit
to fvaleye/delta-rs
that referenced
this pull request
Sep 12, 2025
…ies (delta-io#3713) Adding `cargo machete` to find and remove unused dependencies quickly in the CI. The cargo machete has been run to identify and remove some unused dependencies. A review should be done to ensure that flagged dependencies are truly unused and to avoid false positives. - https://github.com/bnjbvr/cargo-machete Signed-off-by: Florian Valeye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
cargo macheteto find and remove unused dependencies quickly in the CI.The cargo machete has been run to identify and remove some unused dependencies.
A review should be done to ensure that flagged dependencies are truly unused and to avoid false positives.
Documentation