Skip to content

chore(cargo): add cargo-machete to detect and remove unused dependencies #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

chore(cargo): add cargo-machete to detect and remove unused dependencies #3713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ jobs:
- name: Format
run: cargo fmt -- --check

- name: Run Machete to check for unused dependencies
uses: bnjbvr/cargo-machete@main

- name: Default build
run: (cd crates/deltalake && cargo build --tests)

Expand Down
3 changes: 0 additions & 3 deletions crates/aws/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@ aws-config = { version = "1.5", default-features = false, features = [
"behavior-version-latest",
"rt-tokio",
"credentials-process",
"sso",
] }
aws-sdk-sso = { version = "=1.72.0"}
aws-sdk-ssooidc = { version = "=1.73.0"}
aws-sdk-dynamodb = { version = "=1.79.0", default-features = false, features = [
"behavior-version-latest",
"rt-tokio",
Expand Down
4 changes: 0 additions & 4 deletions crates/azure/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,10 @@ rust-version.workspace = true
deltalake-core = { version = "0.28.0", path = "../core", features = ["cloud"] }

# workspace depenndecies
async-trait = { workspace = true }
bytes = { workspace = true }
futures = { workspace = true }
tracing = { workspace = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here @rtyler might say that adding logging to the crates is the way to go and every crate should have tracing as a required dependency :D.

That said, I am fairly sure we already have an issue to track this.

object_store = { workspace = true, features = ["azure"] }
thiserror = { workspace = true }
tokio = { workspace = true }
regex = { workspace = true }
url = { workspace = true }

[dev-dependencies]
Expand Down
12 changes: 0 additions & 12 deletions crates/benchmarks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,12 @@ edition = "2021"
clap = { version = "4", features = [ "derive" ] }
chrono = { version = "0.4.31", default-features = false, features = ["clock"] }
tokio = { version = "1", features = ["fs", "macros", "rt", "io-util"] }
env_logger = "0"

# arrow
arrow = { workspace = true }
arrow-array = { workspace = true }
arrow-buffer = { workspace = true }
arrow-cast = { workspace = true }
arrow-ord = { workspace = true }
arrow-row = { workspace = true }
arrow-schema = { workspace = true, features = ["serde"] }
arrow-select = { workspace = true }
parquet = { workspace = true, features = [
"async",
"object_store",
] }

# serde
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }

# datafusion
Expand Down
6 changes: 5 additions & 1 deletion crates/catalog-glue/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ rust-version.workspace = true

[dependencies]
async-trait = { workspace = true }
aws-config = "1"
aws-config = { version = "1.5", default-features = false, features = [
"behavior-version-latest",
"rt-tokio",
"credentials-process",
] }
aws-sdk-glue = "=1.78.0"
deltalake-core = { version = "0.28.0", path = "../core" }
thiserror = { workspace = true }
Expand Down
3 changes: 3 additions & 0 deletions crates/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,6 @@ required-features = ["datafusion"]
[[test]]
name = "read_delta_partitions_test"
required-features = ["datafusion"]

[package.metadata.cargo-machete]
ignored = ["foyer"]
Comment on lines +170 to +171
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this for now I think.

I believe this may have slipped though while i was working on #3440. It will get added back once we merge that PR, but then potentially also as optional.

3 changes: 3 additions & 0 deletions crates/deltalake/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,6 @@ required-features = ["datafusion"]

[[example]]
name = "recordbatch-writer"

[package.metadata.cargo-machete]
ignored = ["deltalake-catalog-glue"]
1 change: 0 additions & 1 deletion crates/gcp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ tracing = { workspace = true }
object_store = { workspace = true, features = ["gcp"]}
thiserror = { workspace = true }
tokio = { workspace = true }
regex = { workspace = true }
url = { workspace = true }

[dev-dependencies]
Expand Down
1 change: 0 additions & 1 deletion crates/hdfs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ deltalake-core = { version = "0.28.0", path = "../core"}
hdfs-native-object-store = "0.15"

# workspace dependecies
object_store = { workspace = true }
tokio = { workspace = true }
url = { workspace = true }

Expand Down
4 changes: 0 additions & 4 deletions crates/lakefs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,17 @@ deltalake-core = { version = "0.28.0", path = "../core", features = ["cloud"]}
# workspace dependencies
async-trait = { workspace = true }
bytes = { workspace = true }
chrono = { workspace = true }
futures = { workspace = true }
tracing = { workspace = true }
object_store = { workspace = true, features = ["aws"]}
thiserror = { workspace = true }
tokio = { workspace = true }
regex = { workspace = true }
uuid = { workspace = true, features = ["serde", "v4"] }
url = { workspace = true }
dashmap = "6"
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
reqwest = {version = "0.12", default-features = false, features = ["http2", "json", "rustls-tls-native-roots"]}
http = "1.0"
delta_kernel = { workspace = true, features = [] }

[dev-dependencies]
deltalake-core = { path = "../core" }
Expand Down
2 changes: 0 additions & 2 deletions crates/mount/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@ errno = "0.3"
async-trait = { workspace = true }
bytes = { workspace = true }
futures = { workspace = true }
tracing = { workspace = true }
object_store = { workspace = true }
thiserror = { workspace = true }
tokio = { workspace = true }
regex = { workspace = true }
url = { workspace = true }

[dev-dependencies]
Expand Down
1 change: 0 additions & 1 deletion crates/test/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ url = { workspace = true }
dotenvy = "0"
fs_extra = "1.3.0"
futures = { version = "0.3" }
rand = "0.8"
tempfile = "3"
tokio = { version = "1", features = ["macros", "rt-multi-thread"] }

Expand Down
10 changes: 0 additions & 10 deletions python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ serde_json = { workspace = true }
async-trait = { workspace = true }
chrono = { workspace = true }
env_logger = "0"
regex = { workspace = true }
thiserror = { workspace = true }
tracing = { workspace = true }
uuid = { workspace = true, features = ["serde", "v4"] }
parking_lot = "0.12"

Expand All @@ -49,14 +47,6 @@ tokio = { workspace = true, features = ["rt-multi-thread"] }

deltalake-mount = { path = "../crates/mount" }

# catalog-unity
deltalake-catalog-unity = { path = "../crates/catalog-unity", features = [
"aws",
"azure",
"gcp",
"r2",
] }

# Non-unix or emscripten os
[target.'cfg(any(not(target_family = "unix"), target_os = "emscripten"))'.dependencies]
mimalloc = { version = "0.1", default-features = false }
Expand Down
Loading