Skip to content

fix(core): handle Result type after get_actions sync conversion #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2025
+17 −23

Merge branch 'main' into fix/get-actions-result-handling

8893f00
Select commit
Loading
Failed to load commit list.
Merged

fix(core): handle Result type after get_actions sync conversion #3846

Merge branch 'main' into fix/get-actions-result-handling
8893f00
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2025 in 0s

73.76% (-0.03%) compared to ad91db7

View this Pull Request on Codecov

73.76% (-0.03%) compared to ad91db7

Details

Codecov Report

❌ Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.76%. Comparing base (ad91db7) to head (8893f00).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/load_cdf.rs 25.00% 0 Missing and 3 partials ⚠️
crates/core/src/operations/write/mod.rs 0.00% 0 Missing and 3 partials ⚠️
...es/core/src/kernel/transaction/conflict_checker.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
- Coverage   73.78%   73.76%   -0.03%     
==========================================
  Files         152      152              
  Lines       39144    39116      -28     
  Branches    39144    39116      -28     
==========================================
- Hits        28883    28853      -30     
- Misses       8987     8989       +2     
  Partials     1274     1274

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov