feat(unstable): add lint plugin ast types #27977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canac
reviewed
Feb 5, 2025
marvinhagemeister
force-pushed
the
lint-plugin-types2
branch
from
3c77a85 to
55efd5f
Compare
marvinhagemeister
force-pushed
the
lint-plugin-types2
branch
from
55efd5f to
ff163dd
Compare
dsherret
reviewed
Feb 6, 2025
dsherret
reviewed
Feb 6, 2025
| export interface YieldExpression extends AstBase { | ||
| type: "YieldExpression"; | ||
| delegate: boolean; | ||
| argument: Expression | null; |
There was a problem hiding this comment.
It seems sometimes we use | undefined and other times | null. Should we consolidate on one or is this for a certain reason?
There was a problem hiding this comment.
In TSEStree they use null as an empty value for all non-type nodes and undefined as an empty value for type nodes. It's a little weird.
dsherret
reviewed
Feb 6, 2025
dsherret
reviewed
Feb 6, 2025
dsherret
reviewed
Feb 6, 2025
marvinhagemeister
added a commit
that referenced
this pull request
Feb 6, 2025
This PR fixes deviations in our AST format compared to TSEStree. They are mostly a leftover for when I first started working on it and based it off of babel instead. One of the key changes why the changeset is a bit bigger is that TSEStree uses `undefined` instead of `null` as the empty value for type nodes. This is likely influenced by `tsc` which use `undefined` everywhere. The rest of the nodes use `null` though. It's a little weird, but for now it might be better to align. (extracted from #27977)
marvinhagemeister
added a commit
that referenced
this pull request
Feb 7, 2025
This PR strongly types the JS plugin visitor.
```ts
export default {
name: "foo",
rules: {
bar: {
create(ctx) {
return {
// Plain ast node visitor
Identifier(node) {},
// Exit visitor
"Identifier:exit"(node) {},
// Custom selectors, `node` needs to be typed manually
"FunctionDeclaration > Identifier"(node: Deno.lint.Identifier) {}
}
}
}
}
}
```
Follow up to #27977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Fix deviations from TSEStreeDecided to split this PR up into two ones so that this one only has the type changes. The TSEStree fixes are here #27996