fix: wake event loop when V8 posts foreground tasks from background threads by fraidev · Pull Request #32450 · denoland/deno

fraidev · 2026-03-04T10:04:21Z

Closes #14786
Closes #32034

Needs: denoland/rusty_v8#1924

When V8 background threads post foreground tasks (module compilation callbacks, Atomics.waitAsync timeouts, worker lifecycle events), the event loop had no way to know it should wake up and pump those tasks. This caused stalls where programs would hang until an unrelated timer or I/O event happened to fire.

The fix uses rusty_v8's new PlatformImpl trait to create a custom V8 platform (DenoPlatformImpl) that intercepts foreground task posts. When a V8 background thread posts a task for an isolate, the callback looks up that isolate's AtomicWaker in a global registry and wakes the corresponding Tokio task.

libs/core/runtime/jsruntime.rs

bartlomieju · 2026-03-11T17:47:55Z

ext/node/ops/tls.rs

This code seem unrelated to the task at hand?

yeah totally unrelated, this file and the test was from other PR, I removed them.

bartlomieju · 2026-03-11T17:49:01Z

libs/core/runtime/jsruntime.rs

+      std::thread::spawn(move || {
+        std::thread::sleep(std::time::Duration::from_millis(100));
+        flag.store(false, std::sync::atomic::Ordering::Relaxed);
+        waker.wake_by_ref();
+      });


What was the reason to spawn a separate thread and sleep for 100ms? Wouldn't just calling waker.wake() here be sufficient?

you're right, like that worked very well too. fixed!

…hreads

kajukitli

overall direction looks right, but i think there

kajukitli

overall direction looks right, but i think there

kajukitli

real bug in the delayed-task path

DenoPlatformImpl::wake_delayed() spawns a brand new OS thread for every delayed foreground task via std::thread::spawn + sleep.

that means Atomics.waitAsync timeouts can turn into unbounded sleeping threads, because those timeouts are user-controlled. a program can create thousands of delayed tasks and now you've got thousands of sleeping OS threads. that's basically a DoS footgun in core runtime code.

this needs a shared timer queue / scheduler, not one thread per delayed task.

kajukitli

real bug in the delayed-task path

DenoPlatformImpl::wake_delayed() spawns a brand new OS thread for every delayed foreground task via std::thread::spawn + sleep.

that means Atomics.waitAsync timeouts can turn into unbounded sleeping threads, because those timeouts are user-controlled. a program can create thousands of delayed tasks and now you've got thousands of sleeping OS threads. that's basically a DoS footgun in core runtime code.

this needs a shared timer queue / scheduler, not one thread per delayed task.

bartlomieju · 2026-03-11T22:56:59Z

The specs::worker::atomics_wait_async_notify test seems to hang indefinitely after all :(

fraidev · 2026-03-12T01:35:33Z

The specs::worker::atomics_wait_async_notify test seems to hang indefinitely after all :(

Fixed!

kajukitli

rechecked after the last commits — the shared timer queue fixes the big problem i called out earlier. much better than spawning one OS thread per delayed task.

lgtm now

minor note: TimerEntry ordering only compares deadline, so equal-deadline entries are considered equal in ordering even if they target different isolates. that's fine for BinaryHeap correctness here, but if you ever need stable ordering / dedupe semantics, include isolate_key too.

bartlomieju

LGTM, let's land it!

Xenius97 · 2026-03-13T07:25:28Z

Sadly #32450 isn't fixed by this.
I can reproduce my issue, now always happens.

deno 2.7.5+1ea5ff0 (canary, release, x86_64-pc-windows-msvc)
v8 14.6.202.9-rusty
typescript 5.9.2

F:\Git\deno-test>yarn start:dev:v3
yarn run v1.22.22
$ deno run -A --unstable-detect-cjs ./scripts/Runtime.ts --dev --v3
>> Deno is up to date (version 2.7.5+1ea5ff0).
>> Starting full build...
>> Currently using env: .env
>> Building with 25 worker thread(s).
>> Resource test-119 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-119 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resource test-240 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-285 changed, start compiling!
>> Resource test-140 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-285 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-240 finished compiling in 0.16s! (Changed files: manifest.json, server.lua)
>> Resource test-77 changed, start compiling!
>> Resource test-125 changed, start compiling!
>> Resource test-290 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-194 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-125 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-261 changed, start compiling!
>> Resoure test-77 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resoure test-290 finished compiling in 0.15s! (Changed files: manifest.json, server.lua)
>> Resoure test-140 finished compiling in 0.21s! (Changed files: manifest.json, server.lua)
>> Resource test-27 changed, start compiling!
>> Resource test-157 changed, start compiling!
>> Resource test-67 changed, start compiling!
>> Resoure test-194 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-127 changed, start compiling!
>> Resource test-43 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-261 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resource test-388 changed, start compiling!
>> Resoure test-157 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-27 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-384 changed, start compiling!
>> Resoure test-127 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-304 changed, start compiling!
>> Resoure test-388 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resource test-33 changed, start compiling!
>> Resoure test-67 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-43 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-103 changed, start compiling!
>> Resource test-287 changed, start compiling!
>> Resource test-58 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-29 changed, start compiling!
>> Resoure test-384 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-304 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-41 changed, start compiling!
>> Resoure test-33 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-183 changed, start compiling!
>> Resource test-153 changed, start compiling!
>> Resoure test-287 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-346 changed, start compiling!
>> Resoure test-58 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-231 changed, start compiling!
>> Resoure test-29 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-167 changed, start compiling!
>> Resource test-362 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-299 changed, start compiling!
>> Resoure test-103 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-41 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-289 changed, start compiling!
>> Resoure test-183 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-142 changed, start compiling!
>> Resource test-294 changed, start compiling!
>> Resoure test-167 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resoure test-153 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-231 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-193 changed, start compiling!
>> Resource test-3 changed, start compiling!
>> Resource test-245 changed, start compiling!
>> Resoure test-346 finished compiling in 0.16s! (Changed files: manifest.json, server.lua)
>> Resoure test-142 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-296 changed, start compiling!
>> Resoure test-289 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-173 changed, start compiling!
>> Resoure test-294 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-335 changed, start compiling!
>> Resource test-100 changed, start compiling!
>> Resoure test-193 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-299 finished compiling in 0.18s! (Changed files: manifest.json, server.lua)
>> Resource test-242 changed, start compiling!
>> Resoure test-3 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-11 changed, start compiling!
>> Resource test-221 changed, start compiling!
>> Resoure test-362 finished compiling in 0.24s! (Changed files: manifest.json, server.lua)
>> Resoure test-296 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-245 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-173 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-297 changed, start compiling!
>> Resoure test-100 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-335 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-38 changed, start compiling!
>> Resource test-383 changed, start compiling!
>> Resource test-55 changed, start compiling!
>> Resource test-168 changed, start compiling!
>> Resource test-26 changed, start compiling!
>> Resoure test-221 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-242 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-35 changed, start compiling!
>> Resource test-145 changed, start compiling!
>> Resoure test-11 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-38 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-42 changed, start compiling!
>> Resoure test-168 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-276 changed, start compiling!
>> Resoure test-55 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-26 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resoure test-383 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-35 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-82 changed, start compiling!
>> Resoure test-297 finished compiling in 0.15s! (Changed files: manifest.json, server.lua)
>> Resource test-251 changed, start compiling!
>> Resource test-198 changed, start compiling!
>> Resource test-159 changed, start compiling!
>> Resource test-54 changed, start compiling!
>> Resource test-220 changed, start compiling!
>> Resource test-271 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-145 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-308 changed, start compiling!
>> Resoure test-276 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-250 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-358 changed, start compiling!
>> Resoure test-42 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-82 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-178 changed, start compiling!
>> Resoure test-308 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resource test-124 changed, start compiling!
>> Resoure test-220 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-54 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-251 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-319 changed, start compiling!
>> Resource test-136 changed, start compiling!
>> Resoure test-198 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-148 changed, start compiling!
>> Resource test-65 changed, start compiling!
>> Resource test-212 changed, start compiling!
>> Resoure test-159 finished compiling in 0.15s! (Changed files: manifest.json, server.lua)
>> Resoure test-250 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-358 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-78 changed, start compiling!
>> Resource test-219 changed, start compiling!
>> Resoure test-271 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
>> Resource test-175 changed, start compiling!
>> Resoure test-178 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-375 changed, start compiling!
>> Resource test-122 changed, start compiling!
>> Resoure test-78 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resoure test-124 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-349 changed, start compiling!
>> Resoure test-212 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resoure test-319 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-321 changed, start compiling!
>> Resoure test-175 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-49 changed, start compiling!
>> Resource test-130 changed, start compiling!
>> Resource test-117 changed, start compiling!
>> Resoure test-219 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-136 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
>> Resoure test-65 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
>> Resource test-305 changed, start compiling!
>> Resource test-91 changed, start compiling!
>> Resource test-32 changed, start compiling!
>> Resource test-227 changed, start compiling!
>> Resoure test-122 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-148 finished compiling in 0.20s! (Changed files: manifest.json, server.lua)
>> Resoure test-375 finished compiling in 0.15s! (Changed files: manifest.json, server.lua)
>> Resource test-206 changed, start compiling!
>> Resoure test-349 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-203 changed, start compiling!
>> Resoure test-49 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-130 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-117 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-47 changed, start compiling!
>> Resoure test-305 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-248 changed, start compiling!
>> Resource test-239 changed, start compiling!
>> Resoure test-91 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-321 finished compiling in 0.16s! (Changed files: manifest.json, server.lua)
>> Resource test-217 changed, start compiling!
>> Resoure test-32 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-380 changed, start compiling!
>> Resource test-360 changed, start compiling!
>> Resource test-21 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-210 changed, start compiling!
>> Resource test-235 changed, start compiling!
>> Resource test-309 changed, start compiling!
>> Resoure test-203 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-206 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-192 changed, start compiling!
>> Resource test-197 changed, start compiling!
>> Resoure test-380 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-226 changed, start compiling!
>> Resoure test-47 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-227 finished compiling in 0.19s! (Changed files: manifest.json, server.lua)
>> Resoure test-360 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-235 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resoure test-309 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-273 changed, start compiling!
>> Resoure test-217 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resoure test-248 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-239 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-21 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-210 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-85 changed, start compiling!
>> Resource test-376 changed, start compiling!
>> Resource test-31 changed, start compiling!
>> Resource test-200 changed, start compiling!
>> Resource test-313 changed, start compiling!
>> Resource test-24 changed, start compiling!
>> Resoure test-197 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-322 changed, start compiling!
>> Resource test-275 changed, start compiling!
>> Resource test-61 changed, start compiling!
>> Resource test-317 changed, start compiling!
>> Resource test-14 changed, start compiling!
>> Resoure test-192 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-273 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-74 changed, start compiling!
>> Resource test-64 changed, start compiling!
>> Resoure test-275 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-226 finished compiling in 0.18s! (Changed files: manifest.json, server.lua)
>> Resoure test-85 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-399 changed, start compiling!
>> Resource test-56 changed, start compiling!
>> Resoure test-322 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-353 changed, start compiling!
>> Resoure test-313 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resource test-229 changed, start compiling!
>> Resource test-207 changed, start compiling!
>> Resoure test-14 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-200 finished compiling in 0.16s! (Changed files: manifest.json, server.lua)
>> Resoure test-376 finished compiling in 0.16s! (Changed files: manifest.json, server.lua)
>> Resoure test-56 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-24 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
>> Resource test-336 changed, start compiling!
>> Resoure test-317 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
>> Resoure test-74 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-59 changed, start compiling!
>> Resoure test-64 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-61 finished compiling in 0.20s! (Changed files: manifest.json, server.lua)
>> Resoure test-399 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-292 changed, start compiling!
>> Resoure test-31 finished compiling in 0.21s! (Changed files: manifest.json, server.lua)
>> Resource test-156 changed, start compiling!
>> Resource test-269 changed, start compiling!
>> Resource test-52 changed, start compiling!
>> Resource test-366 changed, start compiling!
>> Resource test-104 changed, start compiling!
>> Resource test-141 changed, start compiling!
>> Resoure test-229 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-216 changed, start compiling!
>> Resoure test-353 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-207 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-155 changed, start compiling!
>> Resource test-328 changed, start compiling!
>> Resource test-86 changed, start compiling!
>> Resource test-182 changed, start compiling!
>> Resoure test-59 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-336 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-156 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-72 changed, start compiling!
>> Resource test-341 changed, start compiling!
>> Resource test-307 changed, start compiling!
>> Resoure test-292 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resource test-158 changed, start compiling!
>> Resoure test-269 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resoure test-366 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-2 changed, start compiling!
>> Resoure test-155 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-104 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resoure test-328 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-141 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Worker 3 finished in 2.27s!
>> Resoure test-86 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-216 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resoure test-341 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resoure test-52 finished compiling in 0.17s! (Changed files: manifest.json, server.lua)
>> Resoure test-182 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-72 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-152 changed, start compiling!
>> Resource test-213 changed, start compiling!
>> Resource test-326 changed, start compiling!
>> Resoure test-307 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-288 changed, start compiling!
>> Resource test-71 changed, start compiling!
>> Resource test-44 changed, start compiling!
>> Resoure test-2 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-158 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-233 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resource test-347 changed, start compiling!
>> Resource test-62 changed, start compiling!
>> Resource test-51 changed, start compiling!
>> Resource test-204 changed, start compiling!
>> Resource test-355 changed, start compiling!
>> Resource test-316 changed, start compiling!
>> Resource test-211 changed, start compiling!
>> Resoure test-326 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-288 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-179 changed, start compiling!
>> Resoure test-71 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-233 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-28 changed, start compiling!
>> Resource test-45 changed, start compiling!
>> Resoure test-213 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resoure test-152 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Worker 1 finished in 2.48s!
>> Resource test-241 changed, start compiling!
>> Resoure test-347 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-218 changed, start compiling!
>> Resource test-120 changed, start compiling!
>> Resoure test-62 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-316 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-92 changed, start compiling!
>> Resoure test-204 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resoure test-211 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-334 changed, start compiling!
>> Resoure test-51 finished compiling in 0.15s! (Changed files: manifest.json, server.lua)
>> Resoure test-28 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-355 finished compiling in 0.15s! (Changed files: manifest.json, server.lua)
>> Resoure test-179 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-12 changed, start compiling!
>> Resource test-165 changed, start compiling!
>> Resoure test-44 finished compiling in 0.23s! (Changed files: manifest.json, server.lua)
>> Resoure test-45 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-278 changed, start compiling!
>> Resource test-320 changed, start compiling!
>> Resource test-199 changed, start compiling!
>> Resource test-187 changed, start compiling!
>> Resoure test-218 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-120 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-92 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-241 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-15 changed, start compiling!
>> Resource test-352 changed, start compiling!
>> Worker 5 finished in 2.44s!
>> Resource test-171 changed, start compiling!
>> Resource test-330 changed, start compiling!
>> Resoure test-334 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-5 changed, start compiling!
>> Worker 6 finished in 2.42s!
>> Resoure test-12 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-165 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resoure test-187 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-199 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-373 changed, start compiling!
>> Resoure test-278 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-264 changed, start compiling!
>> Resource test-137 changed, start compiling!
>> Resource test-8 changed, start compiling!
>> Resource test-394 changed, start compiling!
>> Resoure test-320 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-171 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-214 changed, start compiling!
>> Resoure test-352 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-15 finished compiling in 0.14s! (Changed files: manifest.json, server.lua)
>> Resource test-379 changed, start compiling!
>> Resoure test-330 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-149 changed, start compiling!
>> Resource test-318 changed, start compiling!
>> Resource test-16 changed, start compiling!
>> Resoure test-5 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resoure test-8 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resoure test-373 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Worker 8 finished in 2.44s!
>> Resoure test-137 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resource test-99 changed, start compiling!
>> Resoure test-214 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-264 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resoure test-394 finished compiling in 0.11s! (Changed files: manifest.json, server.lua)
>> Resource test-345 changed, start compiling!
>> Resoure test-149 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-379 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resource test-361 changed, start compiling!
>> Resource test-327 changed, start compiling!
>> Worker 4 finished in 2.65s!
>> Resoure test-318 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resource test-270 changed, start compiling!
>> Resoure test-16 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-68 changed, start compiling!
>> Resource test-48 changed, start compiling!
>> Resource test-374 changed, start compiling!
>> Resource test-166 changed, start compiling!
>> Resource test-381 changed, start compiling!
Warning: PO file not found: locales/hu_HU.po
>> Resoure test-345 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-270 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-48 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resource test-53 changed, start compiling!
>> Resoure test-166 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-99 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-170 changed, start compiling!
>> Resource test-70 changed, start compiling!
>> Resource test-267 changed, start compiling!
>> Resource test-256 changed, start compiling!
>> Resoure test-68 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-327 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Worker 9 finished in 2.53s!
>> Resoure test-374 finished compiling in 0.10s! (Changed files: manifest.json, server.lua)
>> Resoure test-361 finished compiling in 0.13s! (Changed files: manifest.json, server.lua)
>> Resource test-151 changed, start compiling!
>> Resource test-389 changed, start compiling!
>> Resource test-291 changed, start compiling!
>> Resoure test-53 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-170 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-381 finished compiling in 0.12s! (Changed files: manifest.json, server.lua)
>> Resource test-30 changed, start compiling!
>> Resoure test-70 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Worker 11 finished in 2.44s!
>> Resource test-247 changed, start compiling!
>> Resource test-395 changed, start compiling!
>> Resoure test-267 finished compiling in 0.08s! (Changed files: manifest.json, server.lua)
>> Resoure test-256 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-151 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-291 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-215 changed, start compiling!
>> Resource test-50 changed, start compiling!
>> Resoure test-389 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-392 changed, start compiling!
>> Resource test-161 changed, start compiling!
>> Resource test-357 changed, start compiling!
>> Resoure test-30 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-370 changed, start compiling!
>> Resoure test-247 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resoure test-395 finished compiling in 0.07s! (Changed files: manifest.json, server.lua)
>> Resource test-110 changed, start compiling!
>> Resoure test-215 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-50 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-161 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-97 changed, start compiling!
>> Resoure test-357 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-392 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-10 changed, start compiling!
>> Resource test-118 changed, start compiling!
>> Resource test-146 changed, start compiling!
>> Resoure test-370 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-205 changed, start compiling!
>> Resource test-163 changed, start compiling!
>> Resource test-196 changed, start compiling!
>> Resoure test-110 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-97 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-10 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-387 changed, start compiling!
>> Resource test-302 changed, start compiling!
>> Resoure test-146 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-205 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-118 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-163 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-196 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-144 changed, start compiling!
>> Worker 15 finished in 2.27s!
>> Resource test-107 changed, start compiling!
>> Resource test-89 changed, start compiling!
>> Resource test-255 changed, start compiling!
>> Resource test-102 changed, start compiling!
>> Resoure test-387 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-79 changed, start compiling!
>> Resoure test-302 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
Warning: PO file not found: locales/hu_HU.po
>> Resource test-382 changed, start compiling!
>> Resoure test-144 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-106 changed, start compiling!
>> Worker 10 finished in 2.71s!
>> Resoure test-107 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resoure test-102 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-255 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-89 finished compiling in 0.06s! (Changed files: manifest.json, server.lua)
>> Resource test-310 changed, start compiling!
>> Resource test-63 changed, start compiling!
>> Resource test-4 changed, start compiling!
>> Resource test-238 changed, start compiling!
>> Resoure test-106 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-382 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-253 changed, start compiling!
>> Resource test-325 changed, start compiling!
>> Resoure test-79 finished compiling in 0.09s! (Changed files: manifest.json, server.lua)
>> Resoure test-310 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-4 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-63 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-238 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-75 changed, start compiling!
>> Resource test-342 changed, start compiling!
>> Resource test-263 changed, start compiling!
>> Resource test-93 changed, start compiling!
>> Resource test-258 changed, start compiling!
>> Resoure test-325 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-253 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-359 changed, start compiling!
>> Resource test-176 changed, start compiling!
>> Resoure test-75 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-93 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-342 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-263 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Worker 13 finished in 2.59s!
>> Resoure test-258 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resource test-262 changed, start compiling!
>> Resource test-60 changed, start compiling!
>> Resource test-101 changed, start compiling!
>> Resource test-18 changed, start compiling!
>> Resoure test-359 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-176 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-329 changed, start compiling!
>> Resource test-272 changed, start compiling!
>> Resoure test-262 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Worker 18 finished in 2.10s!
>> Resoure test-60 finished compiling in 0.05s! (Changed files: manifest.json, server.lua)
>> Resoure test-101 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-18 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-293 changed, start compiling!
>> Resource test-300 changed, start compiling!
>> Resource test-284 changed, start compiling!
>> Resoure test-329 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-272 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-36 changed, start compiling!
>> Resource test-190 changed, start compiling!
>> Resoure test-293 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Worker 17 finished in 2.27s!
>> Resoure test-300 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-284 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-138 changed, start compiling!
>> Resoure test-36 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Worker 16 finished in 2.40s!
>> Resource test-356 changed, start compiling!
>> Resoure test-190 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-13 changed, start compiling!
>> Resoure test-138 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resoure test-356 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-371 changed, start compiling!
>> Resoure test-13 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-260 changed, start compiling!
>> Resource test-259 changed, start compiling!
>> Resoure test-371 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resoure test-260 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-224 changed, start compiling!
>> Resoure test-259 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resource test-385 changed, start compiling!
>> Resource test-143 changed, start compiling!
>> Resoure test-224 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-222 changed, start compiling!
>> Resoure test-385 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-143 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-114 changed, start compiling!
>> Resource test-277 changed, start compiling!
>> Resoure test-222 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Worker 20 finished in 1.97s!
>> Resoure test-114 finished compiling in 0.04s! (Changed files: manifest.json, server.lua)
>> Resoure test-277 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-172 changed, start compiling!
>> Resource test-40 changed, start compiling!
>> Resoure test-172 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resoure test-40 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-80 changed, start compiling!
>> Resource test-46 changed, start compiling!
>> Resoure test-80 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resoure test-46 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-108 changed, start compiling!
>> Resource test-369 changed, start compiling!
>> Resoure test-108 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resoure test-369 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Worker 22 finished in 1.72s!
>> Resource test-188 changed, start compiling!
>> Resoure test-188 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-244 changed, start compiling!
>> Resoure test-244 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-377 changed, start compiling!
>> Resoure test-377 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-180 changed, start compiling!
>> Resoure test-180 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Resource test-112 changed, start compiling!
>> Resoure test-112 finished compiling in 0.03s! (Changed files: manifest.json, server.lua)
>> Worker 25 finished in 1.39s!

workers.log

Log shows worker 2, 7, 12, 14, 19, 21, 23, 24 never finishing.

fraidev marked this pull request as ready for review March 4, 2026 10:04

fraidev marked this pull request as draft March 4, 2026 10:55

fraidev force-pushed the fix/increase-v8-thread-pool branch from 4e0dc76 to bd9b6b1 Compare March 4, 2026 11:50

fraidev changed the title ~~fix: increase V8 platform thread pool to prevent worker startup starv…~~ fix: pump V8 message loop on background task completion to prevent worker stall Mar 4, 2026

fraidev changed the title ~~fix: pump V8 message loop on background task completion to prevent worker stall~~ fix: pump V8 message loop on background tasks to prevent worker stall Mar 4, 2026

fraidev changed the title ~~fix: pump V8 message loop on background tasks to prevent worker stall~~ fix: pump V8 message loop on background tasks to prevent stuck Mar 4, 2026

fraidev force-pushed the fix/increase-v8-thread-pool branch from bd9b6b1 to c9647a2 Compare March 4, 2026 11:52

fraidev marked this pull request as ready for review March 4, 2026 11:52

nathanwhit reviewed Mar 4, 2026

View reviewed changes

libs/core/runtime/jsruntime.rs Outdated Show resolved Hide resolved

fraidev marked this pull request as draft March 4, 2026 15:42

fraidev changed the title ~~fix: pump V8 message loop on background tasks to prevent stuck~~ fix: wake event loop when V8 posts foreground tasks from background threads Mar 5, 2026

fraidev added the ci-draft Run the CI on draft PRs. label Mar 5, 2026

fraidev force-pushed the fix/increase-v8-thread-pool branch 6 times, most recently from ec2a726 to 3f99ebb Compare March 10, 2026 21:04

fraidev removed the ci-draft Run the CI on draft PRs. label Mar 10, 2026

fraidev marked this pull request as ready for review March 10, 2026 21:12

bartlomieju reviewed Mar 11, 2026

View reviewed changes

fraidev force-pushed the fix/increase-v8-thread-pool branch 5 times, most recently from 11145fd to 271c7ae Compare March 11, 2026 20:49

fix: wake event loop when V8 posts foreground tasks from background t…

70fdb9b

…hreads

kajukitli reviewed Mar 11, 2026

View reviewed changes

add atomic tests

253bbf5

fraidev force-pushed the fix/increase-v8-thread-pool branch from 271c7ae to 253bbf5 Compare March 11, 2026 21:31

use a shared timer queue instead

23f1bf2

fraidev requested review from bartlomieju, kajukitli and nathanwhit March 11, 2026 22:06

fix tests

02f753c

kajukitli approved these changes Mar 12, 2026

View reviewed changes

bartlomieju approved these changes Mar 12, 2026

View reviewed changes

fraidev merged commit 0895897 into denoland:main Mar 12, 2026
220 of 222 checks passed

Conversation

fraidev commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bartlomieju Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

fraidev Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

bartlomieju Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

fraidev Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

kajukitli left a comment

Choose a reason for hiding this comment

Uh oh!

kajukitli left a comment

Choose a reason for hiding this comment

Uh oh!

kajukitli left a comment

Choose a reason for hiding this comment

Uh oh!

kajukitli left a comment

Choose a reason for hiding this comment

Uh oh!

bartlomieju commented Mar 11, 2026

Uh oh!

fraidev commented Mar 12, 2026

Uh oh!

kajukitli left a comment

Choose a reason for hiding this comment

Uh oh!

bartlomieju left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Xenius97 commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fraidev commented Mar 4, 2026 •

edited

Loading