feat: store import sites on dependencies#251
Merged
dsherret merged 7 commits intodenoland:mainfrom Apr 4, 2023
Merged
Conversation
dsherret
reviewed
Mar 8, 2023
Member
dsherret
left a comment
dsherret
left a comment
There was a problem hiding this comment.
Looks mostly good to me. @nayeemrmn would you be able to add a basic test for each kind of import?
dsherret
reviewed
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #228. Stops short of introducing
ImportError/ checking assertions because that's where it starts needing to be broken in. They're not included in the json yet since the schema needs a little more scrutiny, but the serialization code is there to iterate on and is usable in the rust API.