Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/shell/execute.rs:753
- [nitpick] Consider checking the capitalization in the error message for consistency with other error messages in the enum. If the style guide requires initial capitalization, update the message accordingly.
#[error("invalid utf-8: {}", err)]
Cargo.toml:28
- [nitpick] Please confirm that the inclusion of the 'winapi' and 'libc' features for sys_traits is intentional and that relevant platform-specific behaviors are covered by tests.
sys_traits = { version = "0.1.9", features = ["real", "winapi", "libc"] }
dsherret
commented
Apr 9, 2025
dsherret
commented
Apr 9, 2025
| return ParseError::fail( | ||
| original_input, | ||
| "Unsupported tilde expansion.", | ||
| ); |
Member
Author
There was a problem hiding this comment.
There's lots of different kinds of tilde expansion. I don't think they're all worth supporting: https://www.gnu.org/software/bash/manual/html_node/Tilde-Expansion.html
dsherret
commented
Apr 9, 2025
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Apr 11, 2025
nayeemrmn
pushed a commit
to denoland/deno
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For denoland/deno#26676
Closes #128