Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/parser.rs:1499
- Review the updated error message for backticks within double quotes to ensure it provides clear guidance to users encountering this parsing failure.
Err("Failed parsing within double quotes. Expected closing backtick."),
dsherret
commented
Apr 9, 2025
| parse_error_failure.message.as_str(), | ||
| } | ||
| ), | ||
| ); |
Member
Author
There was a problem hiding this comment.
These errors are slightly sloppy because it may be parsing an owned value, but this is good enough for now. We can improve this over time.
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Apr 11, 2025
nayeemrmn
pushed a commit
to denoland/deno
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backticks are just command substitution, so no execution changes are necessary.
For denoland/deno#28807