Skip to content

refactor: use String& instead of std::string_view in string_util#1925

Closed
kajukitli wants to merge 1 commit intodenoland:crdtpfrom
kajukitli:fix-stringview
Closed

refactor: use String& instead of std::string_view in string_util#1925
kajukitli wants to merge 1 commit intodenoland:crdtpfrom
kajukitli:fix-stringview

Conversation

@kajukitli
Copy link

Follow-up to #1904

Uses the protocol's String type alias (std::string) directly instead of std::string_view for the CharactersUTF8, CharacterCount, CharactersLatin1, and CharactersUTF16 functions.

This is more consistent with the rest of the codebase and avoids the C++ <string_view> header dependency.

Use the protocol's String type alias (std::string) directly instead of
std::string_view. This is more consistent with the rest of the codebase
and avoids pulling in the C++ string_view header.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kajukitli kajukitli closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants