Skip to content

refactor: use String& instead of std::string_view in string_util #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kajukitli wants to merge 1 commit into from
Closed

refactor: use String& instead of std::string_view in string_util #1925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/deno_inspector/string_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ String StringUtil::fromUTF16LE(const uint16_t* data, size_t length) {
return fromUTF16(data, length); // Assuming host is little-endian
}

const uint8_t* StringUtil::CharactersUTF8(const std::string_view s) {
const uint8_t* StringUtil::CharactersUTF8(const String& s) {
return reinterpret_cast<const uint8_t*>(s.data());
}

size_t StringUtil::CharacterCount(const std::string_view s) {
size_t StringUtil::CharacterCount(const String& s) {
return s.length();
}

Expand Down
8 changes: 4 additions & 4 deletions src/deno_inspector/string_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ struct StringUtil {
static String fromUTF16(const uint16_t* data, size_t length);
static String fromUTF8(const uint8_t* data, size_t length);
static String fromUTF16LE(const uint16_t* data, size_t length);
static const uint8_t* CharactersUTF8(const std::string_view s);
static size_t CharacterCount(const std::string_view s);
static const uint8_t* CharactersUTF8(const String& s);
static size_t CharacterCount(const String& s);

inline static uint8_t* CharactersLatin1(const std::string_view s) {
inline static uint8_t* CharactersLatin1(const String& s) {
return nullptr;
}
inline static const uint16_t* CharactersUTF16(const std::string_view s) {
inline static const uint16_t* CharactersUTF16(const String& s) {
return nullptr;
}
};
Expand Down