103453 - Add validation for VES data - IVC CHAMPVA

[michaelclement]

Summary

This PR adds the first pass at our VES data validator. IVC CHAMPVA form 10-10d will soon be submitting to the new VES CHAMPVA API, so we need to make sure we can appropriately validate our data before sending it to VES.

• Adds new data validator class
• Adds some initial unit tests (more to come in a follow-on PR)

Related issue(s)

• VES: Validate Required Fields va.gov-team#103453

Testing done

• New code is covered by unit tests

Screenshots

NA

What areas of the site does it impact?

None yet; this is not in use anywhere. We're prepping this module for an integration in a coming sprint.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

NA

[github-actions]

1 Warning

⚠️

This PR changes 219 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/ivc_champva/app/services/ivc_champva/ves_data_validator.rb (+108/-0) modules/ivc_champva/spec/services/ves_data_validator_spec.rb (+111/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[michaelclement]

Outside the scope of this ticket, but there will be a followup

[michaelclement]

All methods below this line are the individual validation components we roll together up above.

There are currently some tests, but the goal is to get much wider coverage of these constituent parts in a follow-on PR.