Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBEX] Update 0781 PDF fill of evidence & treatment data #21142

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

freeheeling
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • (Summarize the changes that have been made to the platform)
    • Modifies PDF filler logic based on schema changes to the evidence and treatmentProviders attributes
    • Creates helper methods to aggregate attributes – behaviors, evidence and treatmentProviders – and remove falsy values
    • Adds corresponding tests
    • Updates JSON test files with new schema structure and key names
    • Replaces 2 PDF fixtures to account for schema updates
  • (If bug, how to reproduce) N/A
  • (What is the solution, why is this the solution?)
    • Supports structure of submitted data from vets-website
  • (Which team do you work for, does your team own the maintenance of this component?)
    • Disability Benefits Experience Team 2 (dBeX Carbs 🥖), which owns maintenance of all files in this PR
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
    • evidence and treatmentProviders form data were initially expected to be submitted in whole, not in subgroupings
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • What is the testing plan for rolling out the feature?
    • Rollout will be incremental, once development is complete

What areas of the site does it impact?

  • The generation of data to fill PDF form 21-0781

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@freeheeling freeheeling added disability-experience To manage benefits disability claims experience. disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) labels Mar 6, 2025
@freeheeling freeheeling self-assigned this Mar 6, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/104113-schema-updates-evidence-treatment/main/main March 6, 2025 21:33 Inactive
@freeheeling freeheeling force-pushed the dbex/104113-schema-updates-evidence-treatment branch from 8c0a4b1 to 7bd6d57 Compare March 6, 2025 23:11
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/104113-schema-updates-evidence-treatment/main/main March 6, 2025 23:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/104113-schema-updates-evidence-treatment/main/main March 7, 2025 00:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience. test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants