104641b - Remove champva_enhanced_monitor_logging flipper gates - IVC CHAMPVA forms

[michaelclement]

Summary

This PR removes the champva_enhanced_monitor_logging flipper that has been fully enabled in production for some months now.

Related issue(s)

• Remove flippers that have been fully enabled for over 1 month va.gov-team#104641

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

NA

[michaelclement]

Blocked until #21319 is merged in.

[brostk]

LGTM!

[stevenjcumming]

Please separate the features.yml removal and the code updates

PR 1: Remove feature from code.
PR 2: (deploy to prod) remove feature from features.yml

[michaelclement]

Please separate the features.yml removal and the code updates

PR 1: Remove feature from code. PR 2: (deploy to prod) remove feature from features.yml

Got it - removed the changes to features.yml and moved them to this PR. Please let me know if there's anything else I need to do on this. Thank you!

[stevenjcumming]

@michaelclement I need to clarify my previous comment

Wait to merge the second PR until the first PR has been deployed to production

(sorry, I haven't had enough coffee yet 😆)