Api 55108 v2 val use claim date

[siddharthalamsal]

Summary

V2 validation was largely updated in #27361, this PR is just clean up

• Removes duplicate claim_date function which was using time.date.now.
• Now using claim_date from disability_compensation_validations_helper.rb
• adds check for claimDate not in the future if provided.

Related issue(s)

API-55108

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
  • used time.date.now
• testing:
  • the change is minimal, all tests are passing, should have caught anything
  • v2 526 submissions working as normal with new validation

What areas of the site does it impact?

modules/claims_api/app/controllers/concerns/claims_api/v2/alt_revised_disability_compensation_validation.rb
modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modules/claims_api/spec/controllers/concerns/claims_api/v2/alt_revised_disability_compensation_validation_spec.rb
modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[Copilot]

Pull request overview

Cleans up Claims API v2 526 validation logic by removing the locally-defined claim_date method and reusing the shared implementation from ClaimsApi::DisabilityCompensationValidationsHelper, aligning v2 behavior with other validations.

Changes:

• Include ClaimsApi::DisabilityCompensationValidationsHelper in the v2 disability compensation validation concern and remove the duplicate claim_date method.
• Update v2 validation specs to expect Date.current (matching the helper fallback) instead of Time.zone.today.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb	Removes duplicate claim_date and includes shared validations helper.
modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb	Updates expectations to match shared helper fallback date behavior.

[siddharthalamsal]

noticed claimDate business logic was not being checked before we used it for validations. This probably could have waited until the claimDate was actually added to the schema, so open to revert but I don't think it hurts anything.

[siddharthalamsal]

This was a repeat of the helper file claim_date method

[jeremyhunton-va]

Code looks good to me! I'll pull this down after lunch and do a quick smoke test before I sign off.

[jeremyhunton-va]

LGTM!

[jeremyhunton-va]

LGTM!

[stiehlrod]

The test manually resets @claim_date with instance_variable_set(:@claim_date, nil). This is fine for testing, but note that claim_date in the shared helper uses memoization (@claim_date = ...). If claim_date was previously called in the test setup with a non-future date, and @claim_date isn't reset, the validation would pass incorrectly. The test does reset it, so it works — but this is worth noting as a pattern that couples tests to internal implementation details.