This repository is currently being migrated. It's locked while the migration is in progress.
-
Notifications
You must be signed in to change notification settings - Fork 94
Api 55108 v2 val use claim date #27550
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
03ec21b
use shared helper
siddharthalamsal a3dea9c
require helper
siddharthalamsal 9c4fd6a
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal 4554b02
update spec
siddharthalamsal 5cb1a6e
update spec
siddharthalamsal 2b96d22
private helper methods
siddharthalamsal 715c5c0
add claimDate validation if present
siddharthalamsal 2a47ffc
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal cd0c8e3
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal e947997
remove dupes
siddharthalamsal f1ec987
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal 851b7d7
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal d632710
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal b054557
Merge branch 'master' into api-55108-v2-val-use-claimDate
siddharthalamsal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,13 @@ | |
|
|
||
| require 'claims_api/v2/disability_compensation_shared_service_module' | ||
| require 'claims_api/lighthouse_military_address_validator' | ||
| require 'claims_api/disability_compensation_validations_helper' | ||
|
|
||
| module ClaimsApi | ||
| module V2 | ||
| module DisabilityCompensationValidation # rubocop:disable Metrics/ModuleLength | ||
| include DisabilityCompensationSharedServiceModule | ||
| include DisabilityCompensationValidationsHelper | ||
| include LighthouseMilitaryAddressValidator | ||
|
|
||
| DATE_FORMATS = { | ||
|
|
@@ -51,14 +53,6 @@ def validate_form_526_submission_values(target_veteran) | |
|
|
||
| private | ||
|
|
||
| def claim_date | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a repeat of the helper file |
||
| @claim_date = if date_is_valid?(form_attributes['claimDate'], 'claimDate', true) | ||
| Date.parse(form_attributes['claimDate']) | ||
| else | ||
| Time.zone.today | ||
| end | ||
| end | ||
|
|
||
| def validate_form_526_change_of_address | ||
| return if form_attributes['changeOfAddress'].blank? | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.