update how we set vettec form type to avoid casing issue#27797
Merged
update how we set vettec form type to avoid casing issue#27797
Conversation
jazebnad
previously approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MEB API’s DGI “claim type” formatting to preserve VetTec casing so requests align with DGI’s enum expectations.
Changes:
- Avoids
.capitalizeforVetTecwhen building DGI automation claimant endpoints. - Adjusts
EducationBenefitsController#set_typeto keepVetTeccasing instead of always capitalizing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| modules/meb_api/lib/dgi/automation/service.rb | Special-cases VetTec to avoid .capitalize breaking DGI enum casing. |
| modules/meb_api/app/controllers/meb_api/v0/education_benefits_controller.rb | Sets @form_type without forcing .capitalize for VetTec. |
added 2 commits
April 16, 2026 20:26
…tment-of-veterans-affairs/vets-api into update-form-type-method-for-vettec
jazebnad
approved these changes
Apr 17, 2026
bradbergeron-us
approved these changes
Apr 20, 2026
Contributor
|
@s-caso Is there a ticket associated with this work? Can you link it in the description or update the description with some more information? |
Contributor
Author
|
@rmtolmach added a screen shot of the ticket and a link to it |
rmtolmach
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary