Skip to content

update how we set vettec form type to avoid casing issue #27797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-caso merged 8 commits into from
Apr 22, 2026
Merged

update how we set vettec form type to avoid casing issue #27797

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9ae3304
update how we set vettec form type to avoid casing issue
Apr 16, 2026
fe64cc2
handle type in service method
Apr 16, 2026
21c9442
remove pry
Apr 16, 2026
e9c7bd2
remove safe operator
Apr 16, 2026
dd3073f
Merge branch 'master' into update-form-type-method-for-vettec
s-caso Apr 16, 2026
975383d
refactor based on pr review feedback
Apr 17, 2026
7b0262d
Merge branch 'update-form-type-method-for-vettec' of github.com:depar…
Apr 17, 2026
7cfaacf
update vcr specs
Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/meb_api/app/controllers/meb_api/v0/education_benefits_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ def exclusion_periods
private

def set_type
@form_type = params['type']&.capitalize.presence || 'Chapter33'
type = params['type'].presence || 'Chapter33'
@form_type = type == 'VetTec' ? type : type.capitalize
Comment thread
s-caso marked this conversation as resolved.
Outdated
Comment thread
s-caso marked this conversation as resolved.
Outdated
end
Comment thread
s-caso marked this conversation as resolved.

def dispatch_confirmation_email(email)
Expand Down
3 changes: 2 additions & 1 deletion modules/meb_api/lib/dgi/automation/service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def get_claimant_info(type)
private

def end_point(type)
"claimType/#{type.capitalize}/claimants"
formatted_type = type == 'VetTec' ? type : type.capitalize
"claimType/#{formatted_type}/claimants"
Comment thread
s-caso marked this conversation as resolved.
Outdated
end

def request_headers
Expand Down
Loading