fix(target-size): ignore widgets that are inline with other inline elements#5000
fix(target-size): ignore widgets that are inline with other inline elements#5000
Conversation
WilcoFiers
left a comment
WilcoFiers
left a comment
There was a problem hiding this comment.
I think you went off track with this fix. The real issue I think is much simpler, that we just need to be allow inline-block elements to be considered inline for the purpose of target-size (as that's the permissive approach for it) and for them to be blocks for link-in-text-block (as that's the permissive approach there).
While reviewing #5000 I found the approach wasn't working as I was expecting. Playing around with examples I found a simpler way to do this. IDK if this is everything we should do, but I think this gets us close. I decided to put this in its own PR since this was too much code to put into comments.
…-core into target-size-inline
straker
force-pushed
the
target-size-inline
branch
from
b204032 to
6e35ae1
Compare
chutchins25
left a comment
chutchins25
left a comment
There was a problem hiding this comment.
Review
1. Test describe block uses stale option name (Important)
test/commons/dom/is-in-text-block.js:335
The describe block is labeled 'with options.permissive: true' but the option was renamed to includeInlineBlock (by #5009). Should be updated to match the actual API.
2. Test description contradicts assertion (Important)
test/commons/dom/is-in-text-block.js:387
The test 'returns true if inline-block element has a sibling on the same line' asserts isFalse. The test passes because "world" is shorter than "button 2" so the length comparison fails — but the description claims the opposite result. Please update the description to match the actual expected behavior.
3. PR title typo (Suggestion)
Minor: "wigets" → "widgets" in the PR title.
straker
changed the title
WilcoFiers
left a comment
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM. I contributed too much to this. I don't think I can approve this.
3 participants
Closes: #4392