chore(text-block): suggest changes to PR #5000#5009
Merged
WilcoFiers merged 1 commit intotarget-size-inlinefrom Feb 5, 2026
Merged
chore(text-block): suggest changes to PR #5000#5009WilcoFiers merged 1 commit intotarget-size-inlinefrom
WilcoFiers merged 1 commit intotarget-size-inlinefrom
Conversation
straker
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #5000 I found the approach wasn't working as I was expecting. Playing around with examples I found a simpler way to do this. IDK if this is everything we should do, but I think this gets us close. I decided to put this in its own PR since this was too much code to put into comments.