Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements native log streaming from iOS/Android SDK layers to the Flutter layer, enabling unified logging across all platforms. It also introduces helper default loggers and makes a breaking change by renaming DescopeLogger constructor parameters.
Changes:
- Added native log bridging infrastructure via MethodChannel to stream logs from iOS/Android to Flutter
- Introduced three convenience logger instances:
basicLogger,debugLogger, andunsafeLogger - Breaking Change: Renamed
DescopeLoggerproperty from implicit to explicitleveland added newunsafeproperty (replacing thekDebugModecheck)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Bumped version to 0.9.12 |
| lib/src/sdk/sdk.dart | Updated version and initialized native log bridge |
| lib/src/sdk/config.dart | Added unsafe property, helper loggers, and updated documentation |
| lib/src/internal/others/native_log_bridge*.dart | Added native log bridging implementation for supported and unsupported platforms |
| ios/Classes/DescopePlugin.swift | Added log channel handling and FlutterDescopeLogger implementation |
| ios/Classes/descope-swift-sdk/sdk/SDK.swift | Bumped iOS SDK version |
| ios/Classes/descope-swift-sdk/flows/FlowBridge.swift | Improved webview console logging with proper log levels |
| ios/Classes/descope-swift-sdk/flows/Flow.swift | Added convenience initializer for flow ID |
| android/src/main/kotlin/com/descope/flutter/DescopePlugin.kt | Added log channel handling and FlutterDescopeLogger implementation |
| android/build.gradle | Bumped Kotlin SDK dependency version |
| README.md | Updated logger documentation example |
| CHANGELOG.md | Added changelog entry for this version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shilgapira
previously approved these changes
Jan 15, 2026
Co-authored-by: Gil Shapira <gshapira@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 tasks
|
@itaihanski I've opened a new pull request, #170, to work on those changes. Once the pull request is ready, I'll request review from you. |
shilgapira
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/13711
Description
DescopeLoggerproperties tolevelandunsafeMust