-
Notifications
You must be signed in to change notification settings - Fork 5
Native log streaming #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Native log streaming #169
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8497a42
Update iOS SDK to 0.10.5 and Android SDK to 0.18.0
itaihanski 3ff2dde
Implement log streaming from native layer
itaihanski d594f36
Bump version to 0.9.12
itaihanski fde6be4
Update README.md
itaihanski 61228da
Update lib/src/internal/others/native_log_bridge_native.dart
itaihanski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Native log bridging is only available on iOS and Android. | ||
| // On other platforms, a no-op stub will be used. | ||
| export 'native_log_bridge_unsupported.dart' if (dart.library.io) 'native_log_bridge_native.dart'; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import 'package:flutter/services.dart'; | ||
|
|
||
| import '/src/sdk/config.dart'; | ||
|
|
||
| /// Bridges log streaming from native SDK layers (iOS/Android) to Flutter. | ||
| /// | ||
| /// This class listens on the `descope_flutter/logs` MethodChannel and forwards | ||
| /// received native logs to the Flutter DescopeLogger, which filters based on | ||
| /// its own `level` and `unsafe` settings. | ||
| class NativeLogBridge { | ||
| static const _logChannel = MethodChannel('descope_flutter/logs'); | ||
| static DescopeLogger? _logger; | ||
| static bool _isInitialized = false; | ||
|
|
||
| /// Sets the logger to receive native logs and initializes the channel listener. | ||
| /// | ||
| /// This should be called once during SDK initialization. If [logger] is null, | ||
| /// native logging will not be initialized on the native side. | ||
| static void pipeNativeLogs(DescopeLogger? logger) { | ||
| _logger = logger; | ||
| _initChannelIfNeeded(); | ||
|
|
||
| // Send logger configuration to native if a logger is set | ||
| if (logger != null) { | ||
| final levelString = switch (logger.level) { | ||
| DescopeLogger.error => 'error', | ||
| DescopeLogger.info => 'info', | ||
| _ => 'debug', | ||
| }; | ||
| _logChannel.invokeMethod('configure', { | ||
| 'level': levelString, | ||
| 'unsafe': logger.unsafe, | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| /// Ensures the channel listener is set up. | ||
| static void _initChannelIfNeeded() { | ||
| if (!_isInitialized) { | ||
| _isInitialized = true; | ||
| _logChannel.setMethodCallHandler(_handleNativeLog); | ||
| } | ||
| } | ||
|
|
||
| static Future<dynamic> _handleNativeLog(MethodCall call) async { | ||
| if (call.method == 'log') { | ||
| final logger = _logger; | ||
| if (logger == null) return; | ||
|
|
||
| final args = call.arguments as Map<dynamic, dynamic>; | ||
| final levelString = args['level'] as String; | ||
| final message = args['message'] as String; | ||
| final values = (args['values'] as List<dynamic>).cast<String>(); | ||
|
|
||
| // Convert level string to DescopeLogger level constant | ||
| final int level; | ||
| switch (levelString) { | ||
| case 'error': | ||
| level = DescopeLogger.error; | ||
| break; | ||
| case 'info': | ||
| level = DescopeLogger.info; | ||
| break; | ||
| case 'debug': | ||
| default: | ||
| level = DescopeLogger.debug; | ||
| break; | ||
| } | ||
|
|
||
| // Forward to the Flutter logger, which will filter based on its settings | ||
| logger.log( | ||
| level: level, | ||
| message: message, | ||
| values: values, | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.