Skip to content

Fix for issue 407: open() should acceept "rb" attribute. #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix for issue 407: open() should acceept "rb" attribute. #484

merged 2 commits into from
Aug 21, 2025

Conversation

@daveswork
Copy link
Contributor

This fixes #407

This makes code awkward, as I need to specify "rb" to native paths and "r" to artifactory paths, even they are all binary.
Can open function not throw an error when passing "rb" instead of "r" parameter?

@daveswork daveswork mentioned this pull request Aug 5, 2025
Closed
allburov
allburov approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@allburov allburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

allburov
allburov reviewed Aug 21, 2025
View reviewed changes
@allburov allburov merged commit fb72910 into devopshq:master Aug 21, 2025
6 checks passed
@daveswork daveswork deleted the Fix-Issue-407 branch August 26, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allburov allburov allburov approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

open() should accept "rb" attributes

2 participants

@daveswork @allburov