Skip to content

Fix for issue 407: open() should acceept "rb" attribute. #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix for issue 407: open() should acceept "rb" attribute. #484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d28a5
Fix for issue 407: open() should acceept "rb" attribute.
daveswork Aug 5, 2025
a0bed48
Update artifactory.py
allburov Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion artifactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,7 +2104,7 @@ def open(self, mode="r", buffering=-1, encoding=None, errors=None, newline=None)
HTTPResponse, as if it was a regular filesystem object.
The only difference is that this object doesn't support seek()
"""
if mode != "r" or buffering != -1 or encoding or errors or newline:
if mode not in {"r", "rb"} or buffering != -1 or encoding or errors or newline:
raise NotImplementedError("Only the default open() arguments are supported")

return self._accessor.open(self)
Expand Down