Use PrimitiveType as values of parameter dictionary #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Property
parameters
is defined as[String: Any]
which means that you can return any type of value. It can cause a human error when an event has an arbitrary type as an associated value. For example:It would be great if the compiler can warn you.
Solution
Define a protocol
PrimitiveType
which primitive types such asInt
orString
conform to. Use this protocol as a value ofparameters
dictionary so that the compiler can warn you if you return some wrong type.Discussion
It contains a breaking API change. It should be released with the new major version.