fix: prevent WASM out-of-bounds trap in concurrent generate calls#111
Merged
viviveevee merged 2 commits intodfinity:mainfrom Feb 18, 2026
Merged
Conversation
…inity#109) When multiple icpBindgen plugin instances run concurrently (e.g. several .did files processed during Vite's buildStart), the WASM GenerateResult object could be held across await boundaries in writeBindings(). This was observed to cause intermittent "Out of bounds memory access" traps on the service_ts getter. Extract all strings from the WASM object synchronously immediately after wasmGenerate() and free it explicitly, so that writeBindings operates only on plain JS strings.
Contributor
Author
|
Verified: tested locally against a Vite project with 6 concurrent |
viviveevee
approved these changes
Feb 18, 2026
Contributor
viviveevee
left a comment
viviveevee
left a comment
There was a problem hiding this comment.
Excellent work, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple
icpBindgenplugin instances run concurrently (e.g. several.didfiles processed during Vite'sbuildStart), the WASMGenerateResultobject could be held across await boundaries inwriteBindings(). This was observed to cause intermittent"Out of bounds memory access"traps on theservice_tsgetter.Extract all strings from the WASM object synchronously immediately after
wasmGenerate()and free it explicitly, so thatwriteBindingsoperates only on plain JS strings.Ref: #109