Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/core/generate/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { basename, resolve } from 'node:path';
import { prepareBinding } from './bindings.ts';
import { ensureDir, writeFileSafe } from './fs.ts';
import { type WasmGenerateResult, wasmGenerate, wasmInit } from './rs.ts';
import { wasmGenerate, wasmInit } from './rs.ts';

const DID_FILE_EXTENSION = '.did';

Expand Down Expand Up @@ -122,17 +122,38 @@ export async function generate(options: GenerateOptions) {
},
});

// Extract all strings from the WASM object synchronously before any async
// work and free it explicitly. The GenerateResult is backed by WASM linear
// memory and registered with a FinalizationRegistry whose cleanup timing
// is engine-dependent. Holding the object across await boundaries has been
// observed to cause "Out of bounds memory access" traps when multiple
// generate() calls run concurrently (e.g. several Vite plugin instances).
const bindings = {
declarations_js: result.declarations_js,
declarations_ts: result.declarations_ts,
interface_ts: result.interface_ts,
service_ts: result.service_ts,
};
result.free();

await writeBindings({
bindings: result,
bindings,
outDir,
outputFileName,
output,
force,
});
}

type Bindings = {
declarations_js: string;
declarations_ts: string;
interface_ts: string;
service_ts: string;
};

type WriteBindingsOptions = {
bindings: WasmGenerateResult;
bindings: Bindings;
outDir: string;
outputFileName: string;
output: GenerateOutputOptions;
Expand Down
Loading