Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
aterga
force-pushed
the
arshavir/ID-157
branch
from
cbd3125 to
de2194a
Compare
aterga
commented
Aug 22, 2025
lmuntaner
previously requested changes
Aug 22, 2025
Contributor
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
A few comments.
How did you test it manually?
We need to keep /faq because it's used in II 1.0
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
aterga
commented
Aug 25, 2025
aterga
commented
Aug 25, 2025
aterga
force-pushed
the
arshavir/ID-157
branch
2 times, most recently
from
1a8f192 to
1478950
Compare
aterga
force-pushed
the
arshavir/ID-157
branch
from
1478950 to
01007b0
Compare
aterga
commented
Aug 25, 2025
lmuntaner
reviewed
Aug 26, 2025
Contributor
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
A couple of questions but it looks ready!
sea-snake
approved these changes
Aug 26, 2025
Contributor
sea-snake
left a comment
sea-snake
left a comment
There was a problem hiding this comment.
As discussed in a call, PR keeps most implementation "as is" while adding the minimal changes required to support OPTIONS request.
Collaborator
Author
|
Converting to draft since it's supposed to be included in not the next but the second-next release |
aterga
dismissed
lmuntaner’s stale review
Thanks for the review, addressed all the feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Clients want to get more meaningful responses for OPTIONS requests.
Changes
Remove http_request_update and handle OPTIONS, GET requests via query calls.
Tests
Manual testing, cargo test