feat: Set last_used time upon account sign in#3408
Merged
Conversation
b0037e1 to
6b2c993
Compare
last_used time upon account sign in
last_used time upon account sign inlast_used time upon account sign in
b4d5f9a to
d7d08f6
Compare
added 5 commits
October 17, 2025 09:00
b9d2aa8 to
3d8d3b2
Compare
sea-snake
approved these changes
Oct 17, 2025
Contributor
sea-snake
left a comment
There was a problem hiding this comment.
Very nice! Those additional tests clear up the questions I had.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
According to the latest design, users who enable multiple accounts should see their accounts in the order in which they were last used. This requires that the order of usage is recorded on the Internet Identity backend, since otherwise the order cannot be known across the multiple devices that a user may have.
The storage as well as the canister API already supported
last_usedfield, but it was not being populated.To that end, this PR:
last_usedtimestamps, slightly refactoring the storage code to bring about more clarity.Changes
with_account_mutthat enables writing storage code for editing account details with a single account lookup (rather than one lookup to check if it exists, then another lookup to actually edit the account and record the changes).set_account_last_usedtoStorage, call it fromprepare_account_delegation.set_account_last_usedaccount last used inprepare_account_delegationof the account management modules to populate the field when a delegation is created.Tests