feat: Update last_used timestamp of accounts upon sign-in#3409
Merged
aterga merged 13 commits intoarshvair/update-last-used-account-tiemstampsfrom Oct 13, 2025
Merged
Conversation
aterga
changed the base branch from
main
to
arshvair/update-last-used-account-tiemstamps
aterga
force-pushed
the
arshvair/update-last-used-account-tiemstamps
branch
from
b0037e1 to
6b2c993
Compare
…vair/update-last-used-account-tiemstamps-2
aterga
commented
Oct 13, 2025
aterga
commented
Oct 13, 2025
aterga
merged commit 23f2d5d
into
arshvair/update-last-used-account-tiemstamps
21 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 19, 2025
* save * first * Fix tests * second * Fix tests * clippy * clippy-2 * account creation and management should not bump the last_used timestamp * Undo unneeded test changes * undo unneeded changes * feat: Update `last_used` timestamp of accounts upon sign-in (#3409) * save * first * Fix tests * second * Fix tests * first * Move last_used update to prepare_account_delegation * save-2 * Fix some issues from the parent PR * Apply suggestion from @aterga * Apply suggestion from @aterga * fix * Add integration tests * Add one more integration test * Add unit tests * Fix and refactor after test found a bug * Fix formatting * Fix test * Add comment * Add test * Add test * Fix clippy --------- Co-authored-by: Llorenç <llorenc.muntaner@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR continues the work towards implementing account
last_usedtimestamps.< Previous PR |
Changes
Refresh
last_usedupon successful authentication inget_account_delegation.Tests
last_usedtimestamps are then observable.last_usedtimestamp corresponds to the time when the sign-in took place.