refactor(frontend): Manage tokens modal #5882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2E-tests-final-step
…factor(frontend)/manage-tokens
…' into refactor(frontend)/manage-tokens
…factor(frontend)/manage-tokens
…' into refactor(frontend)/manage-tokens
…factor(frontend)/manage-tokens # Conflicts: # src/frontend/src/lib/components/manage/ManageTokens.svelte # src/frontend/src/lib/components/manage/ManageTokensModal.svelte # src/frontend/src/lib/components/tokens/ModalTokensList.svelte
…' into refactor(frontend)/manage-tokens # Conflicts: # src/frontend/src/lib/components/tokens/ModalTokensList.svelte
…factor(frontend)/manage-tokens
daviddecentage
changed the title
…' into refactor(frontend)/manage-tokens
There was a problem hiding this comment.
To facilitate the review, it would be better to split this PR in smaller scopes, for example, removing the first two elements in two separate PRs, then maybe wrapping in the if condition, or even the usage of ModalTokensList, or the introduction of the the context with the change of the filter logic
…' into refactor(frontend)/manage-tokens
daviddecentage
added a commit
that referenced
this pull request
Apr 22, 2025
# Motivation Adding tests to up coverage so I can merge #5882. The tested component is used there so it is related. # Changes - Adding testIds and tests - Small fix regarding `<p>` in `<p>` warning # Tests Added tests --------- Co-authored-by: Antonio Ventilii <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to new figma designs, we adjust the manage tokens modal.
Changes
ManageTokensandManageTokensModalto useModalTokensListtestIdfor removed button, added general close modaltestIdand adjusted testsTests
Bildschirmaufnahme_20250417_111325.mp4