Skip to content

Fix strings not rendered in user's locale despite having .po entries#4051

Merged
dgtlmoon merged 2 commits intodgtlmoon:masterfrom
skkzsh:fix-not-rendered-locale
Apr 14, 2026
Merged

Fix strings not rendered in user's locale despite having .po entries#4051
dgtlmoon merged 2 commits intodgtlmoon:masterfrom
skkzsh:fix-not-rendered-locale

Conversation

@skkzsh
Copy link
Copy Markdown
Contributor

@skkzsh skkzsh commented Apr 13, 2026

Summary

Some strings in include_subtract.html were not wrapped in the _() translation function, so they were always displayed in English regardless of the user's locale.

before

before

after

after

@skkzsh skkzsh marked this pull request as ready for review April 13, 2026 16:36
@skkzsh skkzsh force-pushed the fix-not-rendered-locale branch from 9376937 to 629374f Compare April 14, 2026 04:41
@dgtlmoon
Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

@dgtlmoon dgtlmoon merged commit b16f74e into dgtlmoon:master Apr 14, 2026
32 checks passed
@skkzsh
Copy link
Copy Markdown
Contributor Author

skkzsh commented Apr 14, 2026

@dgtlmoon Since .mo files are binary, conflicts couldn't be resolved automatically.
I’ve resolved the conflicts by merging origin/master into this branch and regenerating the .mo files using python setup.py compile_catalog.
Thank you!

@skkzsh skkzsh deleted the fix-not-rendered-locale branch April 14, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants