Skip to content

feat(workflow): DLT-3290 add plan for review rules sync automation#1191

Open
belumontoya wants to merge 1 commit intostagingfrom
feat/DLT-3290-review-rules-sync
Open

feat(workflow): DLT-3290 add plan for review rules sync automation#1191
belumontoya wants to merge 1 commit intostagingfrom
feat/DLT-3290-review-rules-sync

Conversation

@belumontoya
Copy link
Copy Markdown
Collaborator

@belumontoya belumontoya commented Apr 10, 2026

🛠️ Type Of Change

  • Feature

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-3290

📖 Description

Adds plan document for automating review rules sync across .claude/rules/, .coderabbit.yaml, and the claude-code-review workflow prompt.

This PR also serves as a test run to verify that both Claude Code Review and CodeRabbit work correctly with the new configurations from #1189:

  • Claude review should complete without hitting error_max_turns (0 permission denials)
  • CodeRabbit should apply the Dialtone-specific path instructions from .coderabbit.yaml

💡 Context

After merging #1189, review rules live in three places. This ticket tracks building the automation to keep them in sync using the existing doc-sync pattern (edit tracker hook → pre-push guard → enforcer skill).

📝 Checklist

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

🔮 Next Steps

  • Observe Claude and CodeRabbit review output on this PR
  • Plan and implement the rules sync automation based on observations

Adds a plan document for automating review rules synchronization (DLT-3290). Proposes extending the existing doc-sync mechanism to keep review rules synchronized across .claude/rules/, .coderabbit.yaml, and the workflow prompt when source files are edited. Includes a mapping table of rule file associations.

Add plan document for syncing review rules across .claude/rules/,
.coderabbit.yaml, and the claude-code-review workflow prompt.

This PR also serves as a test to verify that both Claude Code Review
and CodeRabbit run correctly with the new configurations from #1189.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Walkthrough

A planning document is added that outlines a feature to synchronize review rules across three independent locations—Claude Code rules, .coderabbit.yaml path instructions, and GitHub workflow prompt—by extending an existing doc-sync mechanism triggered on source file edits.

Changes

Cohort / File(s) Summary
Documentation Plan
docs/plans/2026-04-10-review-rules-sync.md
Planning document for DLT-3290 detailing mechanism to sync Claude review rules from source files to .coderabbit.yaml and workflow prompt via edit tracker hook and pre-push guard. Includes source-to-target mapping table.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/DLT-3290-review-rules-sync

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/plans/2026-04-10-review-rules-sync.md`:
- Line 11: The source-list at the top (the list including
`.claude/rules/code-review.md`, `vue-components.md`, `css-utilities.md`,
`design-tokens.md`) is missing `.claude/rules/icons.md` while the sync mapping
table later references `.claude/rules/icons.md` on Lines 29-30; make these
consistent by either adding `.claude/rules/icons.md` to the source-list or
removing it from the mapping table so the automation triggers are unambiguous,
and ensure both the source list and the mapping table reference the exact same
set of filenames (e.g., `.claude/rules/icons.md`,
`.claude/rules/code-review.md`) to avoid mismatch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 83523cb1-2dfa-47bf-b05e-1564a1a2d245

📥 Commits

Reviewing files that changed from the base of the PR and between 0d18635 and 35f8d2c.

📒 Files selected for processing (1)
  • docs/plans/2026-04-10-review-rules-sync.md


Review rules now live in three places that drift independently:

1. `.claude/rules/code-review.md` (+ `vue-components.md`, `css-utilities.md`, `design-tokens.md`) — source of truth for Claude Code local development
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align source-file scope across sections

Line 11 omits .claude/rules/icons.md, but Lines 29-30 include it in the sync mapping. Please keep the source list and mapping table consistent so automation triggers are unambiguous.

Also applies to: 29-30

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/plans/2026-04-10-review-rules-sync.md` at line 11, The source-list at
the top (the list including `.claude/rules/code-review.md`, `vue-components.md`,
`css-utilities.md`, `design-tokens.md`) is missing `.claude/rules/icons.md`
while the sync mapping table later references `.claude/rules/icons.md` on Lines
29-30; make these consistent by either adding `.claude/rules/icons.md` to the
source-list or removing it from the mapping table so the automation triggers are
unambiguous, and ensure both the source list and the mapping table reference the
exact same set of filenames (e.g., `.claude/rules/icons.md`,
`.claude/rules/code-review.md`) to avoid mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants