Skip to content

feat(workflow): DLT-3290 add plan for review rules sync automation #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belumontoya wants to merge 1 commit into
base: staging
Choose a base branch
from
+33 −0
Open

feat(workflow): DLT-3290 add plan for review rules sync automation #1191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions docs/plans/2026-04-10-review-rules-sync.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# DLT-3290: Review Rules Sync

Created: 2026-04-10
Status: PENDING
Type: Feature

## Problem

Review rules now live in three places that drift independently:

1. `.claude/rules/code-review.md` (+ `vue-components.md`, `css-utilities.md`, `design-tokens.md`) — source of truth for Claude Code local development
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align source-file scope across sections

Line 11 omits .claude/rules/icons.md, but Lines 29-30 include it in the sync mapping. Please keep the source list and mapping table consistent so automation triggers are unambiguous.

Also applies to: 29-30

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@docs/plans/2026-04-10-review-rules-sync.md` at line 11, The source-list at
the top (the list including `.claude/rules/code-review.md`, `vue-components.md`,
`css-utilities.md`, `design-tokens.md`) is missing `.claude/rules/icons.md`
while the sync mapping table later references `.claude/rules/icons.md` on Lines
29-30; make these consistent by either adding `.claude/rules/icons.md` to the
source-list or removing it from the mapping table so the automation triggers are
unambiguous, and ensure both the source list and the mapping table reference the
exact same set of filenames (e.g., `.claude/rules/icons.md`,
`.claude/rules/code-review.md`) to avoid mismatch.

2. `.coderabbit.yaml` path_instructions — condensed rules for CodeRabbit PR reviews
3. `.github/workflows/claude-code-review.yml` prompt — condensed rules for Claude CI review

When a rule is added or updated in one place, the others must be updated to match. Currently this is manual and will drift.

## Proposed Solution

Extend the existing doc-sync pattern (edit tracker hook → pre-push guard → enforcer skill) to cover review rule files. When a rule source file is edited, the pre-push guard detects the change and triggers Claude to update the condensed versions in the other two targets.

### Source → Target Mapping

| Source | Targets |
|--------|---------|
| `.claude/rules/code-review.md` | `.coderabbit.yaml`, workflow prompt |
| `.claude/rules/vue-components.md` | `.coderabbit.yaml` Vue section, workflow Vue section |
| `.claude/rules/css-utilities.md` | `.coderabbit.yaml` CSS section |
| `.claude/rules/design-tokens.md` | `.coderabbit.yaml` tokens section |
| `.claude/rules/icons.md` | `.coderabbit.yaml` icons section |

## Status

Awaiting analysis of Claude and CodeRabbit review behavior on this PR before planning implementation.
Loading