Skip to content

fix: NO-JIRA icons build, naming conflict and typo#671

Merged
Julio Ortega (juliodialpad) merged 5 commits intorebrand-2025-betafrom
fix-icons
Mar 14, 2025
Merged

fix: NO-JIRA icons build, naming conflict and typo#671
Julio Ortega (juliodialpad) merged 5 commits intorebrand-2025-betafrom
fix-icons

Conversation

@juliodialpad
Copy link
Copy Markdown
Contributor

@juliodialpad Julio Ortega (juliodialpad) commented Mar 14, 2025 •
edited
Loading

Fix icons build, naming conflict and typo

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Description

  • Moved android icons build out of our normal (web) build process
  • Renamed an icon that had a capital letter in its name
  • Removed dialpad-logo assets from Illustrations

💡 Context

  • Dialpad-logo couldn't be found while trying to imported, found that it was due to a naming conflict with an illustration
  • The android icons build needs Java 17 to be setup properly and it was running on every commit, moved it out as it is not part of our "normal" build process, It'd still build on publish/release, etc.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

@juliodialpad
fix naming
8468e10 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
remove unused illustrations
7732a8f 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
move android icons out of normal (web) build process
2c44368 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@juliodialpad Julio Ortega (juliodialpad) added the no-visual-test Add this tag when the PR does not need visual testing label Mar 14, 2025
@juliodialpad
temp rename to fix error
4f145e3 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
rename to correct name
0911c25 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
Copy link
Copy Markdown
Contributor Author

Julio Ortega (juliodialpad) commented Mar 14, 2025

Going to merge this in, please still review, will revert if something doesn't work properly.

@juliodialpad Julio Ortega (juliodialpad) merged commit de83b22 into rebrand-2025-beta Mar 14, 2025
6 checks passed
@juliodialpad Julio Ortega (juliodialpad) deleted the fix-icons branch March 14, 2025 22:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-671/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-671/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-671/

@francisrupert
Copy link
Copy Markdown
Contributor

Francis Rupert (francisrupert) commented Mar 14, 2025

Removed dialpad-logo assets from Illustrations

...but, now they're gone?

image

@juliodialpad
Copy link
Copy Markdown
Contributor Author

Julio Ortega (juliodialpad) commented Mar 14, 2025

Removed dialpad-logo assets from Illustrations

...but, now they're gone?

image

They're being used indeed, but it's pretty obscure that usage. IDK why they're being categorized as illustrations instead of logos. The documentation around it is completely manual.

Added them back here looks like the issue was actually that the dialtone-icons version wasn't updated as it was not part of the rebrand-2025-beta release process.

Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 8, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone-icons/v4.35.0-rebrand-2025-beta.1
31e7a27 
# [4.35.0-rebrand-2025-beta.1](dialtone-icons/v4.34.1...dialtone-icons/v4.35.0-rebrand-2025-beta.1) (2025-03-14)

### Bug Fixes

* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))

### Documentation

* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 8, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.106.0-rebrand-2025-beta.3
5f197c0 
# [9.106.0-rebrand-2025-beta.3](dialtone/v9.106.0-rebrand-2025-beta.2...dialtone/v9.106.0-rebrand-2025-beta.3) (2025-03-14)

### Bug Fixes

* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 8, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.108.0-rebrand-2025-beta.1
c6d819c 
# [9.108.0-rebrand-2025-beta.1](dialtone/v9.107.1...dialtone/v9.108.0-rebrand-2025-beta.1) (2025-04-07)

### Bug Fixes

* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))
* NO-JIRA $el in vue 3 ([#690](#690)) ([0027ba7](0027ba7))
* NO-JIRA bring dialpad illustration assets back ([e3dc23e](e3dc23e))
* NO-JIRA dialtone icons android build ([#691](#691)) ([8c10768](8c10768))
* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
* NO-JIRA icons-illustrations naming conflicts ([29f1f13](29f1f13))
* **Tooltip:** DP-129564 add overflow-wrap for tooltip ([#687](#687)) ([b6d8256](b6d8256))

### Code Refactoring

* DLT-2334 update design colors documentation ([#679](#679)) ([a22a1c0](a22a1c0))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* DLT-2411 suppress-old-brand-icons ([#680](#680)) ([7f6a35e](7f6a35e))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Button:** DLT-2408 add positive kind ([#681](#681)) ([0265764](0265764))
* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** DLT-2458 wfm extended base colors ([#694](#694)) ([2905279](2905279))
* **Design Tokens:** NO-JIRA positive button border color ([497bba8](497bba8))
* **Design Tokens:** NO-JIRA positive button border color (dark) ([82b8654](82b8654))
* **Design Tokens:** NO-JIRA remap focus color ([e003c8b](e003c8b))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
* **Icon:** DLT-2426 add dialpad meetings icon ([#673](#673)) ([96ba523](96ba523))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 28, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.109.0-rebrand-2025-beta.1
c1338e4 
# [9.109.0-rebrand-2025-beta.1](dialtone/v9.108.0...dialtone/v9.109.0-rebrand-2025-beta.1) (2025-04-11)

### Bug Fixes

* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))
* NO-JIRA bring dialpad illustration assets back ([e3dc23e](e3dc23e))
* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
* NO-JIRA icons-illustrations naming conflicts ([29f1f13](29f1f13))

### Code Refactoring

* DLT-2334 update design colors documentation ([#679](#679)) ([a22a1c0](a22a1c0))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* DLT-2411 suppress-old-brand-icons ([#680](#680)) ([7f6a35e](7f6a35e))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Button:** DLT-2408 add positive kind ([#681](#681)) ([0265764](0265764))
* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** DLT-2458 wfm extended base colors ([#694](#694)) ([2905279](2905279))
* **Design Tokens:** NO-JIRA positive button border color ([497bba8](497bba8))
* **Design Tokens:** NO-JIRA positive button border color (dark) ([82b8654](82b8654))
* **Design Tokens:** NO-JIRA remap focus color ([e003c8b](e003c8b))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
* **Icon:** DLT-2426 add dialpad meetings icon ([#673](#673)) ([96ba523](96ba523))
* **Icons:** [NO-JIRA] new icons dialpad-star ([#706](#706)) ([f38fefd](f38fefd))
* **Illustrations:** DLT-2424 add rebranded illustrations ([#693](#693)) ([6644761](6644761))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Josh Carter (jcarter-dp) pushed a commit that referenced this pull request Apr 28, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.112.0-rebrand-2025-beta.1
cdc7e4d 
# [9.112.0-rebrand-2025-beta.1](dialtone/v9.111.1...dialtone/v9.112.0-rebrand-2025-beta.1) (2025-04-22)

### Bug Fixes

* **Callbar Button With Dropdown:** DLT-2441 add modal false ([#723](#723)) ([b031e78](b031e78))
* **Contact Centers Row:** DLT-2363 update colors on recipes ([#663](#663)) ([aac54e6](aac54e6))
* NO-JIRA bring dialpad illustration assets back ([e3dc23e](e3dc23e))
* NO-JIRA icons build, naming conflict and typo ([#671](#671)) ([de83b22](de83b22))
* NO-JIRA icons-illustrations naming conflicts ([29f1f13](29f1f13))
* NO-JIRA vue 3 v-model corrections ([#711](#711)) ([2d5c646](2d5c646))

### Code Refactoring

* DLT-2334 update design colors documentation ([#679](#679)) ([a22a1c0](a22a1c0))

### Documentation

* **Css Utilities:** NO-JIRA update css utilities demo to emphasize semantic ([#665](#665)) ([520eab4](520eab4))
* DLT-2354 DLT-2331 apply season to doc site and add dialtone logo ([#652](#652)) ([0bd67c5](0bd67c5))
* DLT-2391 color utilities documentation ([#659](#659)) ([4d07c12](4d07c12))
* DLT-2411 suppress-old-brand-icons ([#680](#680)) ([7f6a35e](7f6a35e))
* modify the brand page, remove the word-mark variant, update the logo ([#668](#668)) ([08370f7](08370f7))

### Features

* **Button:** DLT-2408 add positive kind ([#681](#681)) ([0265764](0265764))
* **Design Tokens:** DLT-2352 apply new 2025 reb colors ([#636](#636)) ([40d8f96](40d8f96))
* **Design Tokens:** DLT-2458 wfm extended base colors ([#694](#694)) ([2905279](2905279))
* **Design Tokens:** NO-JIRA positive button border color ([497bba8](497bba8))
* **Design Tokens:** NO-JIRA positive button border color (dark) ([82b8654](82b8654))
* **Design Tokens:** NO-JIRA remap focus color ([e003c8b](e003c8b))
* **Design Tokens:** NO-JIRA unhack tmo theme ([#669](#669)) ([daa0801](daa0801))
* **Design Tokens:** NO-JIRA update critical foreground and border ([ebd2885](ebd2885))
* **Design Tokens:** NO-JIRA updated dark muted foreground color ([f5146cc](f5146cc))
* **Design Tokens:** NO-JIRA updated purples ([099fa4b](099fa4b))
* **Design Tokens:** NO-JIRA updated purples dark mode library connection ([a5aa5ab](a5aa5ab))
* DLT-2329 update Archivo to Season Mix font ([#648](#648)) ([ca8fdcf](ca8fdcf))
* DLT-2350 expand color css utility classes ([#655](#655)) ([1b271f3](1b271f3))
* **Empty State:** DLT-2361 DLT-2362 update icon color ([#651](#651)) ([0be7414](0be7414))
* **Icon:** DLT-2410 new dialpad logo icon and update gradients ([#670](#670)) ([c29ee5a](c29ee5a))
* **Icon:** DLT-2426 add dialpad meetings icon ([#673](#673)) ([96ba523](96ba523))
* **Icons:** [NO-JIRA] new icons dialpad-star ([#706](#706)) ([f38fefd](f38fefd))
* **Icons:** DLT-2494 revert update dialpad logo gradient ([#727](#727)) ([8b33df6](8b33df6))
* **Icons:** DLT-2494 update dialpad logo gradient ([#726](#726)) ([933bb7b](933bb7b))
* **Illustrations:** DLT-2424 add rebranded illustrations ([#693](#693)) ([6644761](6644761))
* **Illustrations:** NO-JIRA new illustrations added ([#718](#718)) ([6b45b79](6b45b79))
* **Linters:** DLT-2395 base color linter rules ([#667](#667)) ([a23e3c6](a23e3c6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fede-dp Federico S (fede-dp) Awaiting requested review from fede-dp

@iropolo Ignacio Ropolo (iropolo) Awaiting requested review from iropolo

@francisrupert Francis Rupert (francisrupert) Awaiting requested review from francisrupert

@braddialpad Brad Paugh (braddialpad) Awaiting requested review from braddialpad

@ninamarina Nina Repetto (ninamarina) Awaiting requested review from ninamarina

Assignees

@juliodialpad Julio Ortega (juliodialpad)

Labels

no-visual-test Add this tag when the PR does not need visual testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliodialpad @francisrupert