Skip to content

fix: NO-JIRA icons build, naming conflict and typo #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julio Ortega (juliodialpad) merged 5 commits into from
Mar 14, 2025
Merged

fix: NO-JIRA icons build, naming conflict and typo #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8468e10
fix naming
juliodialpad Mar 14, 2025
7732a8f
remove unused illustrations
juliodialpad Mar 14, 2025
2c44368
move android icons out of normal (web) build process
juliodialpad Mar 14, 2025
4f145e3
temp rename to fix error
juliodialpad Mar 14, 2025
0911c25
rename to correct name
juliodialpad Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dialtone-icons/android/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
]
}
},
"build": {
"build:android": {
"executor": "nx:run-commands",
"dependsOn": ["clean-dist"],
"options": {
Expand Down
19 changes: 14 additions & 5 deletions packages/dialtone-icons/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"command": "pnpm exec gulp"
},
{
"command": "nx run-many --target=build --projects=dialtone-icons-vue2,dialtone-icons-vue3 --parallel=3 --output-style=stream"
"command": "nx run-many --target=build --projects=dialtone-icons-vue2,dialtone-icons-vue3 --parallel=2 --output-style=stream"
}
],
"parallel": false
Expand All @@ -28,6 +28,17 @@
"{projectRoot}/vue3/dist"
]
},
"build:android": {
"executor": "nx:run-commands",
"options": {
"cwd": "{projectRoot}",
"command": "nx run dialtone-icons-android:build:android --output-style=stream"
},
"outputs": [
"{projectRoot}/android/src/kotlin/icons",
"{projectRoot}/android/src/res/raw"
]
},
"publish": {
"executor": "nx:run-commands",
"options": {
Expand All @@ -42,13 +53,11 @@
}
},
"publish:android-package": {
"dependsOn": ["build:android"],
"executor": "nx:run-commands",
"options": {
"cwd": "{projectRoot}/android",
"commands": [
"./gradlew publishToMavenLocal"
],
"parallel": false
"command": "./gradlew publishToMavenLocal"
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions packages/dialtone-icons/src/keywords-icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,6 @@
]
},
"communication": {
"Simultaneous-ring": [
"simultaneous",
"multi-ring",
"multiple calls",
"phone"
],
"call-abandoned": [
"phone",
"missed",
Expand Down Expand Up @@ -476,6 +470,12 @@
"paper aeroplane",
"submit"
],
"simultaneous-ring": [
"simultaneous",
"multi-ring",
"multiple calls",
"phone"
],
"thread": [
"conversation",
"chat",
Expand Down
76 changes: 0 additions & 76 deletions packages/dialtone-icons/src/keywords-illustrations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,82 +13,6 @@
"blank",
"space"
],
"dialpad-logo-black": [
"logo",
"brand",
"branding",
"dialpad",
"word",
"marketing"
],
"dialpad-logo-inverted": [
"logo",
"brand",
"branding",
"dialpad",
"word",
"marketing"
],
"dialpad-logo-white": [
"logo",
"brand",
"branding",
"dialpad",
"word",
"marketing"
],
"dialpad-logo": [
"logo",
"brand",
"branding",
"dialpad",
"word",
"marketing"
],
"dialpad-mono-black": [
"logo",
"brand",
"branding",
"dialpad",
"monochrome",
"mono",
"unitone",
"solid",
"marketing"
],
"dialpad-mono-inverted": [
"logo",
"brand",
"branding",
"dialpad",
"monochrome",
"mono",
"unitone",
"solid",
"marketing"
],
"dialpad-mono-white": [
"logo",
"brand",
"branding",
"dialpad",
"monochrome",
"mono",
"unitone",
"solid",
"marketing"
],
"dialpad-mono": [
"logo",
"brand",
"branding",
"dialpad",
"monochrome",
"mono",
"unitone",
"solid",
"marketing"
],
"mind": [
"mind"
],
Expand Down
0 ...icons/communication/Simultaneous-ring.svg → ...icons/communication/simultaneous-ring.svg
View file
Open in desktop
File renamed without changes
10 changes: 0 additions & 10 deletions .../dialtone-icons/src/svg/illustrations/spot-illustrations/dialpad-logo-black.svg
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions ...altone-icons/src/svg/illustrations/spot-illustrations/dialpad-logo-inverted.svg
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions .../dialtone-icons/src/svg/illustrations/spot-illustrations/dialpad-logo-white.svg
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions packages/dialtone-icons/src/svg/illustrations/spot-illustrations/dialpad-logo.svg
View file
Open in desktop

This file was deleted.

Loading
Loading