Merged
Conversation
Member
|
Could you rebase this one, then I think it would be ok for merging. |
kphoenix137
force-pushed
the
fix-arrow-pvp
branch
from
2581d5a to
6477d58
Compare
Collaborator
Author
Rebased and ready! |
AJenbo
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasn't sure how to write a title for this one. The player's base damage while holding a bow is modified by cutting the base player damage in half if the hero is not a Rogue. This applies to the character panel damage, and against monsters. The code for this is missing in the
Plr2PlrMHit()function, causing no base damage reduction for non-Rogue heroes. There is no evidence that this is an oversight other than speculation, however I believe this adds consistency. There is also no evidence in favor of no damage reduction for PVP, as this is only a result of missing code, and there is no code that deliberately gives more damage to non-Rogue heroes in PVP.