Character Panel Number spacing#7706
Merged
StephenCWills merged 2 commits intodiasurgical:masterfrom Mar 15, 2025
Merged
Conversation
Collaborator
|
I think if this is rebased on top of the current master and changes to |
kphoenix137
force-pushed
the
char-panel-spacing
branch
from
ff39a5a to
ff78046
Compare
Collaborator
Author
This should be ready now. :) |
glebm
approved these changes
Mar 15, 2025
StephenCWills
approved these changes
Mar 15, 2025
Member
StephenCWills
left a comment
StephenCWills
left a comment
There was a problem hiding this comment.
Short, sweet, cleans out some hardcoded numbers and spacing values. Nothing but good things to say about this PR.
Yggdrasill
pushed a commit
to Yggdrasill/DevilutionX
that referenced
this pull request
Mar 23, 2025
Yggdrasill
pushed a commit
to Yggdrasill/DevilutionX
that referenced
this pull request
Mar 23, 2025
Trihedraf
pushed a commit
to Trihedraf/devilutionX
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #7705
Fixes: #7692
Obsoletes: #7688
Removes hardcoding from the Character Panel for spacing numbers, and prevents them from extending too far onto the box edges.