QOL In Multiplayer games only, Disable new game and quit game menu options when player is Dead

[wkdgmr]

Quality of life change for Multiplayer game sessions only. This is to help prevent accidental gear loss when navigating the menu upon death.

There is a lot of Risk in navigating the menu when the player is dead and their loot is on the ground. One wrong click in a Multiplayer session that is not a rejoinable game can be devastating

QoL

[wkdgmr]

I'm not sure why those other commits are showing. This change is just gamemenu.cpp

[StephenCWills]

Merge will do that. If you make sure your branch is up-to-date before making commits and/or rebase instead of merge, that won't happen. But probably, your tools (Visual Studio?) are doing the merge for you automatically, perhaps without you even realizing.

[wkdgmr]

I guess my question is: If this was approved would I need to redo this PR as this seems scuffed?

[qndel]

I guess my question is: If this was approved would I need to redo this PR as this seems scuffed?

no because we squash commits while merging anyway
your change failed clang format
I still don't know what this is about, maybe add a before/after pic?

[StephenCWills]

@wkdgmr You don't have to be so quick to redo PRs. The one you closed earlier could have been reopened. And Git has the tools to add additional changes or even rewrite history on a branch if you need to. If you want help with these things, I can guide you. Feel free to ask on Discord.

[kphoenix137]

Related PR: #3902 (comment)

[wkdgmr]

I guess my question is: If this was approved would I need to redo this PR as this seems scuffed?

no because we squash commits while merging anyway your change failed clang format I still don't know what this is about, maybe add a before/after pic?

I provided photos above. When the player is dead (in any Multiplayer game session), New Game and Quit Game is disabled and the player can only choose to Restart in Town. This behavior is in line with how Restart in Town is disabled when the player is alive.

The logic behind this is it is fairly common for players to accidentally select New Game or Quit Game after dying in the dungeon. This is a high risk situation when a players loot is dropped and they are forced to interact with the Game Menu in order to proceed. Leaving the game in this state if playing a Multiplayer session that does not have another player in it to keep the game open and rejoinable can result in the loss of gear causing unneeded frustration for the player.

This seems like a pretty straightforward QoL to prevent players from accidentally leaving multiplayer game sessions when forced to interact with the Game Menu upon Death

[wkdgmr]

Closing this PR, as this has already been addressed as per PR: #3902 (comment)