Skip to content

Update pl.po#7750

Merged
AJenbo merged 6 commits intodiasurgical:masterfrom
Pawonashi:master
Apr 12, 2025
Merged

Update pl.po#7750
AJenbo merged 6 commits intodiasurgical:masterfrom
Pawonashi:master

Conversation

@Pawonashi
Copy link
Copy Markdown
Contributor

No changes to the translation yet, syncing the file with my editor first

No changes to the translation yet, syncing the file with my editor first
Translated new strings and fixed various mistakes
@Pawonashi
Copy link
Copy Markdown
Contributor Author

After the first commit to sync the file with no actual changes, I made a second commit with added new translations and various fixes.

@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Mar 4, 2025

@qndel would you be willing to give this a quick look?

Comment thread Translations/pl.po Outdated
Comment on lines +1255 to +1256
"Nienumeryczna wartość dla {0} w kolumnie {1} w pliku {2}, rząd {3} kolumna "
"{4}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Nienumeryczna wartość dla {0} w kolumnie {1} w pliku {2}, rząd {3} kolumna "
"{4}"
"Nienumeryczna wartość {0} dla {1} w pliku {2}, rząd {3} kolumna {4}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for other 2?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it seems I got confused...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only changed this one and left the other 2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm being shown only one suggestion in your message, I don't see other two. I made another commit to address remaining cases.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I made only one suggestion, mentioned it was the same thing in 2 other places ;)

Comment thread Translations/pl.po Outdated
Comment thread Translations/pl.po
Comment thread Translations/pl.po Outdated
#: Source/help.cpp:44
msgid "Shift + Left Mouse Button: Attack without moving"
msgstr "Shift + LPM: Atak w miejscu"
msgstr "Shift + Lewoklik: Atak w miejscu"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPM was ok in my opinion

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been suggested to me by Celestin. Considering that original didn't use abbreviations, I thought it might be a good idea to stick to the same philosophy.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'd actually do "Lewy/prawy przycisk myszy", as my friend said "lewoklik" sounds like some disease and it's also not a word I'm familiar with

@qndel
Copy link
Copy Markdown
Member

qndel commented Mar 5, 2025

@AJenbo any idea what "#, c++-format" is for? Seems it gets removed in this PR, any reason to do it vs keeping it as is?

@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Mar 5, 2025

Afaik it denotes that the string uses printf() formatting, but we moved to fmt, not sure why it was even still there.

Pawonashi and others added 3 commits March 5, 2025 21:48
Correction of a mistake

Co-authored-by: qndel <stefan551@o2.pl>
Correction of a mistake

Co-authored-by: qndel <stefan551@o2.pl>
Changed translations related to "invalid value" errors and changed translations related to mouse buttons
Comment thread Translations/pl.po Outdated
Comment on lines +2458 to +2459
"'Czary' na panelu postaci. Po wykonaniu lewokliku na danym zaklęciu, staje "
"się ono aktywne i gotowe do użycia. Następnie prawoklik na danym terenie, "
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu jeszcze te nieszczęsne lewo/prawokliki zostały

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poprawię.

Comment thread Translations/pl.po Outdated
msgstr ""
"PPM by odczytać, następnie\n"
"LPM na cel"
"Prawy przycisk myszy by czytać,\n"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"odczytać" brzmi lepiej, było ok

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ale się nie mieściło w grze. Jeśli jest o tyle gorzej, to co dłuższe (albo może te które pojawiają się w okienku z instrukcją w trakcie gry) przywrócę do poprzedniego stanu.

Comment thread Translations/pl.po Outdated
#: Source/items.cpp:1764
msgid "Right-click to read"
msgstr "PPM by odczytać"
msgstr "Prawy przycisk myszy by czytać"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jak wyżej

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zaadresowane w nowym commicie.

Reverted mouse button translations for instances, where text appears in the message window and changed one missed instance in help.
@AJenbo
Copy link
Copy Markdown
Member

AJenbo commented Apr 12, 2025

@qndel is this acceptable or are there still things that @Pawonashi needs to address?

@AJenbo AJenbo merged commit 91e6292 into diasurgical:master Apr 12, 2025
23 checks passed
@AJenbo AJenbo mentioned this pull request Apr 12, 2025
Trihedraf pushed a commit to Trihedraf/devilutionX that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants