Remove translation from pad buttons to keys in spellbook#7825
Merged
AJenbo merged 1 commit intodiasurgical:masterfrom Mar 9, 2025
Merged
Remove translation from pad buttons to keys in spellbook#7825AJenbo merged 1 commit intodiasurgical:masterfrom
AJenbo merged 1 commit intodiasurgical:masterfrom
Conversation
AJenbo
approved these changes
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These button translations don't actually do anything useful. Navigation is handled by the
SpellBookMove()function inplrctrls.cpp. We can rely on padmapper to control the automap and trigger theCancelaction while the spellbook is open. The only thing this translation function does is cause weird behaviors unrelated to spellbook, like theYbutton will open the chat or the d-pad will move the automap around.