Fix debug command for talking to towners#7826
Merged
AJenbo merged 1 commit intodiasurgical:masterfrom Mar 10, 2025
Merged
Conversation
AJenbo
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugTalkToTowner()is currently no longer able to find any towners at all. This is because it searches by towner name, buttownerData.init()doesn't populatetowner.name. It needs to invokeInitTownerInfo(), but it can't do that since that function requires us to pass an index to theTownersarray.Incidentally, the
DebugCmdVisitTowner()function uses a lookup table to find towners not only by name, but also by shortened descriptions such assmith,witch, orbmaid. The only downside is that it's not case-insensitive, but I figure someone can add that if they need it.This PR splits the
InitTownerInfo()function in two so thatDebugTalkToTowner()can pass aTownerinstance that is not a member of theTownersarray. It also updatesDebugCmdTalkToTowner()to use the same logic asDebugCmdVisitTowner()to make the towner search logic a bit more consistent.